Skip to content

[Partner Nodes] feat(Alibaba): add support for HappyHorse 1.1 model#14581

Merged
bigcat88 merged 2 commits into
masterfrom
feat/api-nodes/HappyHorse-1.1
Jun 23, 2026
Merged

[Partner Nodes] feat(Alibaba): add support for HappyHorse 1.1 model#14581
bigcat88 merged 2 commits into
masterfrom
feat/api-nodes/HappyHorse-1.1

Conversation

@bigcat88

@bigcat88 bigcat88 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

This PR adds support for a new version of HappyHorse

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

Signed-off-by: bigcat88 <bigcat88@icloud.com>
@bigcat88 bigcat88 marked this pull request as ready for review June 22, 2026 20:05
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

comfy_api_nodes/nodes_wan.py is updated to support HappyHorse 1.1 model versions across all three node variants. The define_schema() method in each node (HappyHorseTextToVideoApi, HappyHorseImageToVideoApi, HappyHorseReferenceVideoApi) now exposes happyhorse-1.1-t2v, happyhorse-1.1-i2v, and happyhorse-1.1-r2v options respectively, with updated ratio and template sizing. Each node's price_badge expression is changed to select different per-resolution PPS rate tables depending on whether the chosen model string contains "1.1". Two new image validation helpers (validate_image_aspect_ratio, validate_image_dimensions) are imported and applied in execute() for the I2V and R2V nodes, enforcing minimum dimensions and aspect-ratio constraints on input images. The empty-media error message in HappyHorseReferenceVideoApi is also updated.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding support for HappyHorse 1.1 model versions from Alibaba across multiple node variants.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description is related to the changeset, specifically mentioning the addition of HappyHorse 1.1 support, which aligns with the file changes updating model versions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bigcat88 bigcat88 merged commit 0a92ed1 into master Jun 23, 2026
22 checks passed
@bigcat88 bigcat88 deleted the feat/api-nodes/HappyHorse-1.1 branch June 23, 2026 10:29
@bigcat88 bigcat88 mentioned this pull request Jun 23, 2026
8 tasks
@bigcat88 bigcat88 restored the feat/api-nodes/HappyHorse-1.1 branch June 24, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants