Skip to content

[Partner Nodes] revert last 3 PRs#14602

Merged
comfyanonymous merged 3 commits into
masterfrom
revert/partner-nodes-pending-proxy
Jun 23, 2026
Merged

[Partner Nodes] revert last 3 PRs#14602
comfyanonymous merged 3 commits into
masterfrom
revert/partner-nodes-pending-proxy

Conversation

@bigcat88

@bigcat88 bigcat88 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Reverting next PRs:

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

bigcat88 added 3 commits June 23, 2026 19:37
…e node (#14597)"

Temporarily revert the three most recent Partner Nodes feature additions
(Grok 1080p, SeeDance 2.0 4K, HappyHorse 1.1) pending matching backend
updates. They will be restored once verified end-to-end.

This reverts commit 0f949d0.
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Three sets of video node configuration changes are applied across separate provider files. In nodes_bytedance.py, Seedance 2.0 pricing is refactored to use a SEEDANCE2_PRICE_PER_1K_TOKENS table keyed by (model_id, has_video_input), the 4k resolution is removed from all three Seedance 2.0 nodes, and _seedance2_price_extractor no longer accepts a resolution parameter. In nodes_grok.py, the grok-imagine-video-1.5 API model ID is changed to the preview variant, 1080p is removed from resolution options, pricing constants are revised, and a runtime 1080p validation check is deleted. In nodes_wan.py, HappyHorse model variants switch from 1.1 to 1.0, pricing badges are simplified to a fixed per-second table, and dimension/aspect-ratio validations are removed from the Image-to-Video and Reference-to-Video execute methods.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title '[Partner Nodes] revert last 3 PRs' clearly indicates the PR reverts three partner node changes, which directly aligns with the changeset modifications removing 4K, 1080p, and 1.1 model features from Bytedance, Grok, and Wan nodes.
Description check ✅ Passed The description explicitly lists the three PRs being reverted with their GitHub URLs and provides clear context that these are temporary reverts pending backend updates, directly corresponding to the changes in the raw summary.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@comfy_api_nodes/nodes_wan.py`:
- Line 2162: The validation error message in the ValueError contains a
duplicated word "reference reference" which should be just "reference". Locate
the error message that reads "At least one reference reference image must be
provided." and remove the duplicate "reference" word so it reads "At least one
reference image must be provided."
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 750f17b6-e37e-4324-bbbd-2cdc03177d6d

📥 Commits

Reviewing files that changed from the base of the PR and between 0f949d0 and 10a53a6.

⛔ Files ignored due to path filters (1)
  • comfy_api_nodes/apis/bytedance.py is excluded by !comfy_api_nodes/apis/**
📒 Files selected for processing (3)
  • comfy_api_nodes/nodes_bytedance.py
  • comfy_api_nodes/nodes_grok.py
  • comfy_api_nodes/nodes_wan.py

)
if not media:
raise ValueError("At least one reference image must be provided.")
raise ValueError("At least one reference reference image must be provided.")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Fix duplicated word in the validation error text.

Line 2162 says "reference reference image", which is a user-facing typo.

Suggested patch
-            raise ValueError("At least one reference reference image must be provided.")
+            raise ValueError("At least one reference image must be provided.")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
raise ValueError("At least one reference reference image must be provided.")
raise ValueError("At least one reference image must be provided.")
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@comfy_api_nodes/nodes_wan.py` at line 2162, The validation error message in
the ValueError contains a duplicated word "reference reference" which should be
just "reference". Locate the error message that reads "At least one reference
reference image must be provided." and remove the duplicate "reference" word so
it reads "At least one reference image must be provided."

@comfyanonymous comfyanonymous merged commit 4a03056 into master Jun 23, 2026
17 checks passed
@comfyanonymous comfyanonymous deleted the revert/partner-nodes-pending-proxy branch June 23, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants