Skip to content

tests: use resolved LLVM_SPIRV in promoteInt tests #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvelesko merged 2 commits into from
Aug 19, 2026
Merged

tests: use resolved LLVM_SPIRV in promoteInt tests #1388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ff80ec
tests: use resolved LLVM_SPIRV in promoteInt tests
zqb-all Jul 29, 2026
44e18a4
tests: fall back to a real llvm-spirv when the translator is NOT_NEEDED
pvelesko Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion tests/compiler/promoteInt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ endif()
# If we have this, a pass won't help
# list(APPEND TEST_IR_FILES ${CMAKE_CURRENT_SOURCE_DIR}/func-return-nonstd.ll)

# LLVM_SPIRV holds the translator resolved by FindLLVM.cmake, which may live
# outside LLVM_TOOLS_BINARY_DIR when one is passed via -DLLVM_SPIRV=. It carries
# the sentinel "NOT_NEEDED" when chipStar targets LLVM's integrated SPIR-V
# backend; these tests still translate to SPIR-V to validate the pass output, so
# they fall back to a translator sitting next to the other LLVM tools.
set(PROMOTE_INT_LLVM_SPIRV "${LLVM_SPIRV}")
if(NOT PROMOTE_INT_LLVM_SPIRV OR PROMOTE_INT_LLVM_SPIRV STREQUAL "NOT_NEEDED")
set(PROMOTE_INT_LLVM_SPIRV "${LLVM_TOOLS_BINARY_DIR}/llvm-spirv")
endif()

foreach(IR_FILE ${TEST_IR_FILES})
get_filename_component(FILENAME ${IR_FILE} NAME)
get_filename_component(BASENAME ${IR_FILE} NAME_WE)
Expand All @@ -60,7 +70,7 @@ foreach(IR_FILE ${TEST_IR_FILES})
NAME hipPromoteInt-${BASENAME}
COMMAND env
LLVM_OPT=${LLVM_TOOLS_BINARY_DIR}/opt
LLVM_SPIRV=${LLVM_TOOLS_BINARY_DIR}/llvm-spirv
LLVM_SPIRV=${PROMOTE_INT_LLVM_SPIRV}
LLVM_DIS=${LLVM_TOOLS_BINARY_DIR}/llvm-dis
HIP_SPV_PASSES_LIB=${CMAKE_BINARY_DIR}/lib/libLLVMHipSpvPasses.so
${CMAKE_CURRENT_BINARY_DIR}/run_promote_int_pass.bash ${CMAKE_CURRENT_BINARY_DIR}/${FILENAME}
Expand Down
Loading