tests: use resolved LLVM_SPIRV in promoteInt tests - #1388
Merged
Merged
Conversation
${LLVM_TOOLS_BINARY_DIR}/llvm-spirv not work for
Debian/Ubuntu llvm-spirv-N, which is /usr/bin/llvm-spirv-N
FindLLVM.cmake forces LLVM_SPIRV to the sentinel NOT_NEEDED when chipStar targets LLVM's integrated SPIR-V backend, so the promoteInt tests invoked NOT_NEEDED as a program and all nine failed on the LLVM 22 native lane.
pvelesko
force-pushed
the
llvm-spirv-path
branch
from
August 19, 2026 10:44
6ccf3fa to
44e18a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${LLVM_TOOLS_BINARY_DIR}/llvm-spirv not work for
Debian/Ubuntu llvm-spirv-N, which is /usr/bin/llvm-spirv-N