fix: perspective mod compatibility and improve mixin compatibility#8487
fix: perspective mod compatibility and improve mixin compatibility#8487Lopesnextgen wants to merge 1 commit into
Conversation
|
LB has FreeLook too. All mixin-related stuffs pending for 26.2 update |
|
Yeah, I know LB has FreeLook. This PR is more about mod compatibility than adding a FreeLook feature. External perspective mods like Lunar's currently break because LB still applies CHANGE_LOOK rotation in third person. If mixin changes are on hold until 26.2, I can remove that part and keep only the first-person guard in RotationManager |
|
I will convert all |
|
You can keep your branch and wait for update, then resolve conflicts |
|
Alright! I'll keep the PR open and update/rebase the branch after 26.2 lands, then resolve any conflicts. |
|
|
I trust this repo will become 26.2 earlier than Lunar. So if you want to play on it please test and send the result to support email/bot, or open an issue here |
|
Update the branch |
Per review feedback on CCBlueX#8487, the @WrapOperation variant was overkill for a plain cancel-or-run check. Reverting to @WrapWithCondition and returning !event.isCancelled() is the same behavior with one less indirection.
3 participants
Right now LiquidBounce forces the player's body to rotate when moving the mouse in 3rd person (F5). This breaks mods like Lunar's Perspective/Freelook because the character keeps turning while you're just trying to look around.
I've added a check so mouse input only affects the player's body in first-person. This doesn't break any internal features or modules, and it works perfectly with both Lunar's freelook and Liquid's own modules.
I also updated the Mixin in MixinMouseHandler to use @WrapOperation to ensure better compatibility with other mods. Simple fix, but makes the client much more compatible with modern modpacks...