fix: perspective mod compatibility and improve mixin compatibility#8561
Merged
MukjepScarlet merged 2 commits intoJun 26, 2026
Merged
Conversation
Contributor
|
I'm sorry but my previous comment is incorrect. I will fix it now |
MukjepScarlet
force-pushed
the
fix/perspective-mod-compatibility
branch
from
4585199 to
4bf7f48
Compare
Per maintainer feedback, CHANGE_LOOK is intended to work on all camera types. The Perspective mod case is already handled by the cancelable MouseRotationEvent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening the work from #8487. The branch got deleted by accident on my end, which also closed the PR, so this is a fresh PR rebased on nextgen (26.2).
Same two changes as before:
First-person guard in RotationManager. CHANGE_LOOK only fires when cameraType.isFirstPerson(). In F5 the mouse only moves the camera now, which is what Lunar's Freelook and other perspective mods expect. No effect on LiquidBounce's own FreeLook;
MixinMouseHandler moved from @WrapWithCondition to @WrapOperation, per the suggestion in the original PR thread to convert to the new mixin extras once 26.2 was in.
Diff is still +9/-8 on the same two files, no new code beyond the rebase.