01a09c2f - Filter the inbox by Direct, Contact, or Damus - #178
Merged
Merged
Conversation
TaprootFreakAI
marked this pull request as ready for review
September 13, 2026 20:55
TaprootFreakAI
marked this pull request as draft
September 14, 2026 05:08
TaprootFreakAI
force-pushed
the
01a09c2f-inbox-from-me
branch
from
September 14, 2026 06:43
8cf239b to
2e78b60
Compare
TaprootFreakAI
changed the title
TaprootFreakAI
marked this pull request as ready for review
September 14, 2026 08:03
TaprootFreakAI
marked this pull request as draft
September 14, 2026 08:12
TaprootFreakAI
force-pushed
the
01a09c2f-inbox-from-me
branch
from
September 14, 2026 08:41
49253b8 to
172a46c
Compare
TaprootFreakAI
marked this pull request as ready for review
September 14, 2026 08:49
TaprootFreakAI
marked this pull request as draft
September 14, 2026 09:07
TaprootFreakAI
force-pushed
the
01a09c2f-inbox-from-me
branch
from
September 14, 2026 09:30
0aac4ae to
b8f6016
Compare
TaprootFreakAI
changed the title
TaprootFreakAI
marked this pull request as ready for review
September 14, 2026 09:56
TaprootFreakAI
marked this pull request as draft
September 14, 2026 10:05
TaprootFreakAI
force-pushed
the
01a09c2f-inbox-from-me
branch
from
September 14, 2026 10:12
774ffd2 to
986f8b3
Compare
TaprootFreakAI
marked this pull request as ready for review
September 14, 2026 10:36
TaprootFreakAI
marked this pull request as draft
September 14, 2026 11:07
TaprootFreakAI
force-pushed
the
01a09c2f-inbox-from-me
branch
from
September 14, 2026 11:14
65ffc86 to
65c796e
Compare
TaprootFreakAI
marked this pull request as ready for review
September 14, 2026 11:36
TaprootFreakAI
marked this pull request as draft
September 14, 2026 11:40
TaprootFreakAI
force-pushed
the
01a09c2f-inbox-from-me
branch
from
September 14, 2026 12:06
ef8dc9c to
02b14ce
Compare
TaprootFreakAI
changed the title
TaprootFreakAI
marked this pull request as ready for review
September 14, 2026 12:39
TaprootFreakAI
marked this pull request as draft
September 14, 2026 13:41
TaprootFreakAI
force-pushed
the
01a09c2f-inbox-from-me
branch
from
September 14, 2026 13:44
02b14ce to
3628339
Compare
The Nachrichten list prefixes the viewer's last message with You:/Du: instead of attributing it to the counterpart. Thread bubbles for fromMe messages sit on the right and show You. Incoming last text is unchanged.
Tailwind class order and the sent-preview ternary must match the repo Prettier config so lint stays green.
The list prefix is only visible on the conversation list. The post test now clears ?c= and rerenders after All conversations so lastFromMe can be observed.
The loader post test asserts the sent bubble (You, data-from-me) on the thread. The You: list prefix is covered by InboxScreen tests.
Only fromMe messages get ml-8 self-end. Incoming cards stay the previous full-width class so Linux visual baselines do not change.
The mock GET /conversations drops empty and outbound-only threads to match the api. You: still prefixes lastFromMe on listed two-way rows.
member_platform rows with any message stay listed so ContactLoader can open ?c= after send. Outbound-only Direct threads stay omitted.
POST /contact and ContactLoader look up member_platform, so a Direct chat named 21.gifts is not reused and still listed after send.
Linux Chromium goldens now show You: on the list and a right-aligned You bubble in the thread, in all four viewport/theme combos.
Incoming thread bubbles stay muted and left; sent bubbles and list previews use filled app-btn on the right so direction is obvious.
Incoming thread cards stay full width so contact-success pixels do not move. Only sent bubbles, sent-preview chips, and thread goldens change. CONTRIBUTING forbids incidental baseline diffs.
The default Nachrichten baseline is the inbox overview: a private Direct thread, the official Contact ticket, and Damus.
The Nachrichten list has a chooser at the top. Default Direct shows private PMs only; Contact and Damus are separate.
Linux thread snapshots follow the unified design-system chrome on develop.
The screen-variant catalog listed member profile variants twice. Contact send again asserts the official thread URL and body.
Empty inbox copy is per origin and the Direct/Contact/Damus control stays visible, same as the forum mode switcher.
The lastFromMe behavior spec omitted location on /me, so accountSchema parse failed and hid the filter, then clicked Contact on the Direct default. Use a Direct Bob row with lastFromMe, matching sent-preview. Split the inbox empty-state table so Prettier accepts docs/ui.md.
TaprootFreakAI
force-pushed
the
01a09c2f-inbox-from-me
branch
from
September 14, 2026 16:22
ec05279 to
c45c4e4
Compare
Collaborator
Author
|
EN: DE: DetailsHead Pass 1 (previous head): empty-state table overflowed Prettier; lastFromMe e2e omitted Paired API PR is 21gifts/api#130 and should merge first. Human merge only. |
TaprootFreakAI
marked this pull request as ready for review
September 14, 2026 16:47
TaprootFreak
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
The Nachrichten list is incoming threads only. At the top you choose Direct, Contact, or Damus so private PMs and official tickets are not mixed. Sent bubbles stay filled on the right.
DE:
Die Nachrichten-Liste zeigt nur eingehende Threads. Oben wählt man Direkt, Kontakt oder Damus, damit private PNs und offizielle Tickets nicht gemischt sind. Gesendete Blasen bleiben rechts gefüllt.
Details
Paired API PR 21gifts/api#130. Default filter Direct. Linux goldens:
screen-messages(Direct),state-messages-contact,state-messages-damus, sent-preview, empty.state-contact-successunchanged.