Skip to content

01a09f9d - Show photos on member posts and replies feeds - #189

Merged
TaprootFreak merged 7 commits into
developfrom
01a09f9d-member-post-photos
Sep 14, 2026
Merged

TaprootFreak merged 7 commits into
developfrom
01a09f9d-member-post-photos

Conversation

@TaprootFreakAI

@TaprootFreakAI TaprootFreakAI commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

EN:
Member Beiträge and Antworten feeds now load inline photos the same way the home forum does.
The posts-open-photo baseline shows that photo as a large image on the card; posts-open is the same feed with text only.
Pinned profile notes with photos are included. Nested thread replies stay text-only because ForumBoard does not paint photos there.

DE:
Die Feeds Beiträge und Antworten auf der Mitgliederseite laden Inline-Fotos wie das Home-Forum.
Die Baseline posts-open-photo zeigt das Foto als großes Bild in der Karte; posts-open ist derselbe Feed nur mit Text.
Die angepinnte Profilnotiz mit Foto ist eingeschlossen. Verschachtelte Thread-Antworten bleiben text-only, weil ForumBoard dort keine Fotos zeichnet.

Details

The member profile stacked ForumBoard with empty photoUrls. Auth is a Bearer token in JS memory, so a raw img src cannot send it. This copies the forum fetchMessagePhoto blob-URL path into MemberProfileScreen.

The reviewable proof is the four state-members-posts-open-photo-* PNGs: 1 posts pressed, Carol's card, and a large inline image (the e2e 1×1 JPEG paints as a black square, same as /welcome photo). Compare with state-members-posts-open-*, which shows the text "Second post from Carol." and no image. Desktop shots scroll the photo into the viewport so it is not clipped to a sliver.

@TaprootFreakAI
TaprootFreakAI force-pushed the 01a09f9d-member-post-photos branch 2 times, most recently from a702718 to dc2f658 Compare September 14, 2026 13:40
@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 14, 2026 15:07
@TaprootFreakAI
TaprootFreakAI marked this pull request as draft September 14, 2026 15:53
@TaprootFreakAI
TaprootFreakAI force-pushed the 01a09f9d-member-post-photos branch from bc474bd to 5c72d37 Compare September 14, 2026 17:07
MemberProfileScreen loads fetchMessagePhoto blob URLs for displayed
hasPhoto cards and passes them into ForumBoard, matching the home forum.
Handbook Purpose now lists visible member photos as the pinned note
and the posts/replies feeds, matching ForumBoard top-level cards.
The Beiträge photo fix needs a baseline that actually shows the image,
same ForumBoard paint as the welcome photo card.
Linux Chromium actuals show the inline photo on the Beiträge feed.
Desktop viewport otherwise clips the image to a sliver under the card.
The previous two pushes landed too close; GitHub never started the suite.
The posts-open-photo shots scroll the inline photo into view so
the large ForumBoard image is visible, not a clipped sliver.
@TaprootFreakAI
TaprootFreakAI force-pushed the 01a09f9d-member-post-photos branch from 5c72d37 to 62d3d0e Compare September 14, 2026 17:48
@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 1 review pass.
Member posts feeds load inline photos, and the posts-open-photo baselines show that large photo.

DE:
Bereit nach 1 Review-Durchlauf.
Member-Beiträge laden Inline-Fotos, und die posts-open-photo-Baselines zeigen dieses grosse Foto.

Details

Head 62d3d0e45449af6f9e83f56c528f74d22071050a (verified). Rebased onto develop after #184/#178/#191. Conflict paths were only docs/handbook/*.md; TypeScript auto-merged without markers. Four-lane review was STATUS complete / 0 findings at 5c72d37ca5f1d469bdfce8db490d968bf88acfb3 and is not repeated (markdown-only rebase).

One Codex logic note on blob-URL revoke timing was dismissed because it matches the existing ForumLoader sequence and is already covered by a MemberProfileScreen unmount test.

@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 14, 2026 17:52
@TaprootFreak
TaprootFreak merged commit bf59f3c into develop Sep 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants