Skip to content

01a09247 - Add historical CHF, EUR, and PHP to gift stats - #117

Merged
TaprootFreak merged 3 commits into
developfrom
01a09247-stats-fiat-chf-eur-php
Sep 14, 2026
Merged

TaprootFreak merged 3 commits into
developfrom
01a09247-stats-fiat-chf-eur-php

Conversation

@TaprootFreakAI

Copy link
Copy Markdown
Collaborator

EN:
Public gift totals now also include historical CHF, EUR, and PHP next to Bitcoin and USD.
Each gift is still valued at that UTC day's Coinbase BTC-USD close; the extra fiats are that USD amount converted with Frankfurter ECB rates (last business day when the market was closed).
Missing CHF/EUR/PHP is null and does not take the page down; a missing BTC-USD close still returns 503.

DE:
Die öffentlichen Gift-Totals enthalten neben Bitcoin und USD jetzt auch historische CHF, EUR und PHP.
Jeder Gift wird weiter am Coinbase-BTC-USD-Schluss des UTC-Tags bewertet; die zusätzlichen Fiats sind dieser USD-Betrag, umgerechnet mit Frankfurter-ECB-Kursen (letzter Werktag, wenn der Markt zu war).
Fehlende CHF/EUR/PHP sind null und legen die Seite nicht um; ein fehlender BTC-USD-Schluss bleibt 503.

Details

GET /gifts/stats and GET /gifts?day= keep fx.quote as BTC-USD so existing clients keep parsing.
Additive fields: totalChf, totalEur, totalPhp (and the same on series, recipients, months, and per-gift amounts).
fx.quotes lists USD always, then CHF/EUR/PHP when at least one selected gift day has that cross.
Rates persist in usd_fiat_daily. FRANKFURTER_RATES_URL is optional.

@TaprootFreakAI
TaprootFreakAI force-pushed the 01a09247-stats-fiat-chf-eur-php branch from 1a690af to 096a33b Compare September 12, 2026 08:40
@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 12, 2026 09:42
@TaprootFreakAI
TaprootFreakAI force-pushed the 01a09247-stats-fiat-chf-eur-php branch 2 times, most recently from 502150b to 8fdaf55 Compare September 12, 2026 12:11
@TaprootFreakAI
TaprootFreakAI marked this pull request as draft September 14, 2026 05:07
GET /gifts/stats and GET /gifts?day= still convert each gift at that UTC
day's Coinbase BTC-USD close. CHF/EUR/PHP are that USD amount converted
with Frankfurter ECB USD crosses (last business day when the market was
closed). Missing fiat is null and does not 503 the page.
Handbook and CONTRIBUTING now mention the USD-fiat book the same way as
BTC-USD. The usdCentsToFiatCents e2e title matches the empty-stats skip
pattern used for satsToUsdCents.
@TaprootFreakAI
TaprootFreakAI force-pushed the 01a09247-stats-fiat-chf-eur-php branch from 8fdaf55 to d0696b3 Compare September 14, 2026 05:11
@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 3 review passes.
Public gift stats now also report historical CHF, EUR, and PHP next to Bitcoin and USD.

DE:
Bereit nach 3 Review-Durchläufen.
Die öffentlichen Gift-Statistiken zeigen neben Bitcoin und USD auch historische CHF, EUR und PHP.

Details

Head 9af58d7afdd488d0e4519cd84d58c7eb7841cc18 (signed, verified).

Review passes:
1–2. Original Grok+Codex quality/logic at the pre-rebase heads (0 findings after handbook/e2e-title follow-ups).
3. Rebase onto current develop (notification store + additive fiat). Conflict paths included src/lib/boot-stores.ts and src/server.ts, so the four lanes ran again at this head: Grok quality+logic 0, Codex quality+logic 0.

Local-check: typecheck, lint, handbook:check, e2e:check, test:coverage 100% (11808/4354/646), build.
CI at this head: the Check job SUCCESS.
Comment-gate at post time: the previous completion comment was deleted so this is the last issue comment.

@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 14, 2026 06:59
@TaprootFreak
TaprootFreak merged commit 4196fb4 into develop Sep 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants