Skip to content

01a09247 - Offer CHF, EUR, USD, and PHP next to Bitcoin stats - #164

Merged
TaprootFreak merged 3 commits into
developfrom
01a09247-stats-fiat-currencies
Sep 14, 2026
Merged

TaprootFreak merged 3 commits into
developfrom
01a09247-stats-fiat-currencies

Conversation

@TaprootFreakAI

@TaprootFreakAI TaprootFreakAI commented Sep 12, 2026 •

Copy link
Copy Markdown
Collaborator

EN:
Public /stats and /stats/{day} keep ₿ as the primary amount and offer a CHF, EUR, USD, or PHP equivalent.
Charts switch ₿ | selected fiat. The signed-in profile chart stays ₿ | USD.
Needs 21gifts/api#117 for the new stats fields in production.

DE:
Öffentliche /stats und /stats/{day} behalten ₿ als Hauptbetrag und bieten ein CHF-, EUR-, USD- oder PHP-Äquivalent.
Diagramme schalten ₿ | gewähltes Fiat. Das Profil-Chart bleibt ₿ | USD.
Braucht 21gifts/api#117 für die neuen Stats-Felder in Produktion.

Details

Fiat picker is a four-way SegmentedControl (no ₿ in that control). Locale defaults: de→CHF, fil→PHP, es→EUR, en→USD.
Null fiat amounts render as an em dash. Linux Chromium goldens for the stats shots that now include FiatPicker are in this PR.

@TaprootFreakAI
TaprootFreakAI force-pushed the 01a09247-stats-fiat-currencies branch from ee9c315 to 4012eb4 Compare September 12, 2026 11:24
@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 3 review passes.
Public stats offer CHF, EUR, USD, and PHP next to Bitcoin amounts.

DE:
Bereit nach 3 Review-Durchläufen.
Öffentliche Stats bieten CHF, EUR, USD und PHP neben den Bitcoin-Beträgen.

Details

Head 4012eb423ab6279fc714bfd523aabbabaef0fc07 (signed, verified).

Review passes:

  1. Grok quality: 6 findings (missing Linux stats goldens, formatUsdDisplay unused in KPI, formatUsdTick e2e on the wrong chart, handbook Used-by, docs/ui.md still USD-only). Grok logic: 0.
  2. Goldens + USD KPI wiring. Grok quality+logic: 0. Codex quality: FiatPicker 'use client' and giftStatsFxSchema TSDoc (fixed). Per-fiat visual variants rejected (spec keeps stats-usd-scale as the fiat-scale state). Codex logic mixed-null-as-0 rejected (spec: null is 0 for scale; em dash when the series is unsummable).
  3. Grok quality+logic: 0. Codex quality: 0. Codex logic locale-follow-on-language-switch rejected (spec is the mount-time default).

Comment-gate at post time: no issue comments, reviews, or inline threads.
CI at this head: Check + E2E behavior + four Visual combos green.
Mergeability was still computing at post time.

@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 12, 2026 11:50
@TaprootFreakAI
TaprootFreakAI force-pushed the 01a09247-stats-fiat-currencies branch 2 times, most recently from ecd8dac to 92c09b2 Compare September 12, 2026 12:12
@TaprootFreakAI
TaprootFreakAI marked this pull request as draft September 14, 2026 05:07
@TaprootFreakAI
TaprootFreakAI force-pushed the 01a09247-stats-fiat-currencies branch from 92c09b2 to db51fed Compare September 14, 2026 05:13
@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 14, 2026 06:19
@TaprootFreakAI
TaprootFreakAI marked this pull request as draft September 14, 2026 07:00
The /stats dashboard and /stats/{day} table keep ₿ as the primary amount
and add a four-way fiat picker. Charts switch ₿ | selected fiat. Profile
activity stays ₿ | USD.
Linux Chromium baselines now include FiatPicker. The formatUsdTick e2e
title targets the profile chart; stats over-time stays on formatFiatTick.
…tats routes.

FiatPicker has no state or browser APIs; both callers are already client.
giftStatsFxSchema TSDoc now names BTC-USD plus CHF/EUR/PHP quotes on
GET /gifts/stats and GET /gifts?day=.
@TaprootFreakAI
TaprootFreakAI force-pushed the 01a09247-stats-fiat-currencies branch from db51fed to 5a5bc5d Compare September 14, 2026 07:00
@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 14, 2026 07:04
@TaprootFreak
TaprootFreak merged commit d0abecb into develop Sep 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants