Repository navigation
Conversation
Author
|
@jamadden The Python 3.15 job is failing for reasons unrelated to relstorage. We have therefore prevented this failure from cancelling the other jobs. Could you please start the GitHub Actions? |
Author
|
See: zodb/perfmetrics#44 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent CI-hardening fixes, no runtime changes:
Silence
arguments-differfalse positives (W0221) insrc/relstorage/adapters/interfaces.pyandsrc/relstorage/cache/interfaces.py.zope.interfacemethoddeclarations intentionally omit
selfby convention; newerpylint/astroid (4.x, as installed on the Python 3.14 lint job)
compares them against
InterfaceBase/InterfaceClassdunders(
__call__,__str__,__contains__,__iter__) and reports amismatch. The suppression follows the pattern these files already
use for other interface-style checks
(
no-self-argument,signature-differs, ...).Set
fail-fast: falseon the test matrix so the knownPython
3.15-devsegfault (aperfmetricsC-accelerator issue,under investigation upstream — unrelated to this change) does not
cancel the remaining matrix jobs. The 3.15-dev job itself stays
red as a canary until the upstream issue is resolved.