Skip to content

Link d_cursor_mng for all Wii versions#3164

Open
caseif wants to merge 1 commit into
zeldaret:mainfrom
caseif:d_csr_mng-2
Open

Link d_cursor_mng for all Wii versions#3164
caseif wants to merge 1 commit into
zeldaret:mainfrom
caseif:d_csr_mng-2

Conversation

@caseif

@caseif caseif commented May 24, 2026

Copy link
Copy Markdown
Contributor

This PR links d_cursor_mng for all Wii versions and also adds a new TU to hold the global flag which was previously placed in the former.

The reported .data regressions in m_Re_controller_pad are related to a preexisting ordering issue and aren't actually true regressions - objdiff is only picking up on it differently due to splits fixes.

@decomp-dev

decomp-dev Bot commented May 24, 2026

Copy link
Copy Markdown

Report for GZ2J01 (3f24f43 - 54a5eb7)

No changes

Report for DZDE01 (3f24f43 - 54a5eb7)

📈 Matched code: 52.11% (+0.02%, +1576 bytes)
📈 Linked code: 0.42% (+0.04%, +3640 bytes)
📈 Matched data: 53.47% (+0.03%, +1024 bytes)
📈 Linked data: 0.50% (+0.01%, +392 bytes)

✅ 19 new matches
Unit Item Bytes Before After
framework/d/d_cursor_mng .data +183 38.33% 100.00%
framework/d/d_cursor_mng .sdata +29 36.53% 100.00%
framework/m_Do/m_Do_main .sbss +10 75.00% 100.00%
framework/m_Do/m_Do_printf .sbss +10 80.00% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::list_c::release(unsigned short) +9 92.12% 100.00%
framework/d/d_cursor_mng mDoGph_gInf_c::csr_c::isPointer() +8 0.00% 100.00%
framework/d/d_rvl_fb_copy .sbss +8 0.00% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::update_() +7 98.66% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::bloObj_c::createPaneObj(dCsr_mng_c::bloObj_c::paneObj_c**, J2DPane*) +1 99.78% 100.00%
framework/m_Do/m_Do_printf OSReportDisable +1 98.33% 100.00%
framework/m_Do/m_Do_printf OSReportEnable +1 98.33% 100.00%
framework/m_Do/m_Do_printf mDoPrintf_VReport +1 99.73% 100.00%
framework/m_Do/m_Do_printf OSReport_FatalError +1 99.83% 100.00%
framework/m_Do/m_Do_printf OSReport_System +1 99.64% 100.00%
framework/m_Do/m_Do_audio mDoAud_resetProcess() +1 99.38% 100.00%
framework/m_Do/m_Do_audio mDoAud_resetRecover() +1 99.52% 100.00%
framework/m_Re/m_Re_controller_pad wpad_free(void*) +1 99.58% 100.00%
framework/d/d_cursor_mng .sbss -4 80.00% 100.00%
framework/m_Do/m_Do_audio .data -11 97.98% 100.00%
🥀 1 broken match
Unit Item Bytes Before After
framework/m_Re/m_Re_controller_pad .data +2 100.00% 54.55%
📈 13 improvements in unmatched items
Unit Item Bytes Before After
framework/m_Do/m_Do_audio .sbss +16 32.00% 50.00%
framework/m_Do/m_Do_printf OSReport_Warning +1 99.50% 99.75%
framework/m_Do/m_Do_graphic mDoGph_Painter() +1 97.71% 97.71%
framework/d/d_s_play dScnPly_Delete(dScnPly_c*) +1 93.61% 93.65%
framework/m_Do/m_Do_main main01() 0 22.60% 22.61%
framework/m_Do/m_Do_printf OSReport_Error 0 99.67% 99.92%
framework/m_Do/m_Do_Reset mDoRst_reset(int, unsigned long, int) 0 99.82% 99.88%
framework/d/d_error_msg dShutdownErrorMsg_c::execute() 0 87.34% 87.42%
framework/d/d_s_logo dScnLogo_c::~dScnLogo_c() 0 91.07% 91.08%
framework/d/d_s_logo dScnLogo_c::create() 0 99.83% 99.92%
framework/d/d_s_play dScnPly_Execute(dScnPly_c*) 0 95.70% 95.90%
framework/d/d_s_play phase_00(dScnPly_c*) 0 99.41% 99.71%
framework/d/d_s_play phase_4(dScnPly_c*) 0 99.86% 99.88%

Report for RZDE01_00 (3f24f43 - 54a5eb7)

📈 Matched code: 46.87% (+0.01%, +1160 bytes)
📈 Linked code: 0.71% (+0.03%, +3640 bytes)
📈 Matched data: 53.03% (+0.01%, +384 bytes)
📈 Linked data: 2.20% (+0.01%, +392 bytes)

✅ 12 new matches
Unit Item Bytes Before After
framework/d/d_cursor_mng .data +183 38.33% 100.00%
framework/d/d_cursor_mng .sdata +30 47.62% 100.00%
framework/m_Do/m_Do_main .sbss +12 88.89% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::list_c::release(unsigned short) +9 92.12% 100.00%
framework/d/d_cursor_mng mDoGph_gInf_c::csr_c::isPointer() +8 0.00% 100.00%
framework/d/d_rvl_fb_copy .sbss +8 0.00% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::update_() +7 98.66% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::bloObj_c::createPaneObj(dCsr_mng_c::bloObj_c::paneObj_c**, J2DPane*) +1 99.78% 100.00%
framework/m_Re/m_Re_controller_pad wpad_free(void*) +1 99.58% 100.00%
framework/d/d_s_logo dScnLogo_c::create() +1 99.83% 100.00%
framework/d/d_s_play phase_00(dScnPly_c*) +1 99.71% 100.00%
framework/d/d_cursor_mng .sbss -1 40.00% 100.00%
🥀 1 broken match
Unit Item Bytes Before After
framework/m_Re/m_Re_controller_pad .data +2 100.00% 54.55%
📈 5 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_s_play dScnPly_Delete(dScnPly_c*) +1 93.61% 93.65%
framework/m_Do/m_Do_main main01() 0 15.95% 15.96%
framework/m_Do/m_Do_graphic mDoGph_Painter() 0 97.78% 97.78%
framework/d/d_s_logo dScnLogo_c::~dScnLogo_c() 0 99.97% 99.99%
framework/m_Do/m_Do_audio .data -12 96.05% 98.02%

Report for RZDE01_02 (3f24f43 - 54a5eb7)

📈 Matched code: 54.52% (+0.01%, +1160 bytes)
📈 Linked code: 0.61% (+0.04%, +3640 bytes)
📈 Matched data: 54.54% (+0.03%, +992 bytes)
📈 Linked data: 0.56% (+0.01%, +392 bytes)

✅ 13 new matches
Unit Item Bytes Before After
framework/d/d_cursor_mng .data +183 38.33% 100.00%
framework/d/d_cursor_mng .sdata +30 47.62% 100.00%
framework/m_Do/m_Do_main .sbss +12 88.89% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::list_c::release(unsigned short) +9 92.12% 100.00%
framework/d/d_cursor_mng mDoGph_gInf_c::csr_c::isPointer() +8 0.00% 100.00%
framework/d/d_rvl_fb_copy .sbss +8 0.00% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::update_() +7 98.66% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::bloObj_c::createPaneObj(dCsr_mng_c::bloObj_c::paneObj_c**, J2DPane*) +1 99.78% 100.00%
framework/m_Re/m_Re_controller_pad wpad_free(void*) +1 99.58% 100.00%
framework/d/d_s_logo dScnLogo_c::create() +1 99.83% 100.00%
framework/d/d_s_play phase_00(dScnPly_c*) +1 99.71% 100.00%
framework/d/d_cursor_mng .sbss -1 40.00% 100.00%
framework/m_Do/m_Do_audio .data -11 97.98% 100.00%
🥀 1 broken match
Unit Item Bytes Before After
framework/m_Re/m_Re_controller_pad .data +2 100.00% 54.55%
📈 4 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_s_play dScnPly_Delete(dScnPly_c*) +1 93.61% 93.65%
framework/m_Do/m_Do_main main01() 0 22.62% 22.63%
framework/m_Do/m_Do_graphic mDoGph_Painter() 0 97.76% 97.76%
framework/d/d_s_logo dScnLogo_c::~dScnLogo_c() 0 99.97% 99.99%

Report for Shield (3f24f43 - 54a5eb7)

📈 Matched code: 50.27% (+0.00%, +492 bytes)

✅ 3 new matches
Unit Item Bytes Before After
framework/m_Do/m_Do_audio mDoAud_resetProcess() +1 99.38% 100.00%
framework/m_Do/m_Do_audio mDoAud_resetRecover() +1 99.52% 100.00%
framework/m_Do/m_Do_Reset mDoRst_reset(int, unsigned long, int) +1 99.94% 100.00%
📈 5 improvements in unmatched items
Unit Item Bytes Before After
framework/m_Do/m_Do_audio mDoAud_Create() +1 91.05% 91.12%
framework/m_Do/m_Do_audio mDoAud_Execute() 0 59.35% 59.57%
framework/d/d_error_msg dShutdownErrorMsg_c::execute() 0 87.34% 87.42%
framework/d/d_s_play dScnPly_Execute(dScnPly_c*) 0 75.33% 75.45%
framework/d/d_s_play phase_4(dScnPly_c*) 0 99.92% 99.94%

Report for ShieldD (3f24f43 - 54a5eb7)

📈 Matched code: 54.46% (+0.01%, +1652 bytes)

✅ 5 new matches
Unit Item Bytes Before After
framework/d/d_com_inf_game mDoGph_gInf_c::csr_c::isPointer() +8 0.00% 100.00%
framework/d/d_vibration dComIfGs_checkOptVibration() +5 91.67% 100.00%
framework/d/d_meter2 dMeter2_c::checkStatus() +5 99.73% 100.00%
framework/d/d_meter2 dComIfGp_getItemLifeCountType() +5 90.91% 100.00%
framework/d/d_meter2 dComIfG_play_c::getItemLifeCountType() +3 70.00% 100.00%
📈 3 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_com_inf_game .data +26 73.86% 75.03%
framework/d/d_meter2 .data +23 9.83% 12.47%
framework/d/d_menu_option dMenu_Option_c::initialize() +5 64.47% 67.71%

Report for RZDJ01 (3f24f43 - 54a5eb7)

📈 Matched code: 53.70% (+0.01%, +1160 bytes)
📈 Linked code: 0.61% (+0.04%, +3640 bytes)
📈 Matched data: 54.28% (+0.03%, +992 bytes)
📈 Linked data: 0.56% (+0.01%, +392 bytes)

✅ 13 new matches
Unit Item Bytes Before After
framework/d/d_cursor_mng .data +183 38.33% 100.00%
framework/d/d_cursor_mng .sdata +30 47.62% 100.00%
framework/m_Do/m_Do_main .sbss +12 88.89% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::list_c::release(unsigned short) +9 92.12% 100.00%
framework/d/d_cursor_mng mDoGph_gInf_c::csr_c::isPointer() +8 0.00% 100.00%
framework/d/d_rvl_fb_copy .sbss +8 0.00% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::update_() +7 98.66% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::bloObj_c::createPaneObj(dCsr_mng_c::bloObj_c::paneObj_c**, J2DPane*) +1 99.78% 100.00%
framework/m_Re/m_Re_controller_pad wpad_free(void*) +1 99.58% 100.00%
framework/d/d_s_logo dScnLogo_c::create() +1 99.83% 100.00%
framework/d/d_s_play phase_00(dScnPly_c*) +1 99.71% 100.00%
framework/d/d_cursor_mng .sbss -1 40.00% 100.00%
framework/m_Do/m_Do_audio .data -11 97.98% 100.00%
🥀 1 broken match
Unit Item Bytes Before After
framework/m_Re/m_Re_controller_pad .data +2 100.00% 54.55%
📈 4 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_s_play dScnPly_Delete(dScnPly_c*) +1 93.61% 93.65%
framework/m_Do/m_Do_main main01() 0 22.62% 22.63%
framework/m_Do/m_Do_graphic mDoGph_Painter() 0 97.76% 97.76%
framework/d/d_s_logo dScnLogo_c::~dScnLogo_c() 0 87.42% 87.43%

Report for RZDP01 (3f24f43 - 54a5eb7)

📈 Matched code: 53.32% (+0.01%, +924 bytes)
📈 Linked code: 0.61% (+0.04%, +3640 bytes)
📈 Matched data: 53.93% (+0.03%, +992 bytes)
📈 Linked data: 0.56% (+0.01%, +392 bytes)

✅ 12 new matches
Unit Item Bytes Before After
framework/d/d_cursor_mng .data +183 38.33% 100.00%
framework/d/d_cursor_mng .sdata +30 47.62% 100.00%
framework/m_Do/m_Do_main .sbss +12 88.89% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::list_c::release(unsigned short) +9 92.12% 100.00%
framework/d/d_cursor_mng mDoGph_gInf_c::csr_c::isPointer() +8 0.00% 100.00%
framework/d/d_rvl_fb_copy .sbss +8 0.00% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::update_() +7 98.66% 100.00%
framework/d/d_cursor_mng dCsr_mng_c::bloObj_c::createPaneObj(dCsr_mng_c::bloObj_c::paneObj_c**, J2DPane*) +1 99.78% 100.00%
framework/m_Re/m_Re_controller_pad wpad_free(void*) +1 99.58% 100.00%
framework/d/d_s_play phase_00(dScnPly_c*) +1 99.71% 100.00%
framework/d/d_cursor_mng .sbss -1 40.00% 100.00%
framework/m_Do/m_Do_audio .data -11 97.98% 100.00%
🥀 1 broken match
Unit Item Bytes Before After
framework/m_Re/m_Re_controller_pad .data +2 100.00% 54.55%
📈 5 improvements in unmatched items
Unit Item Bytes Before After
framework/d/d_s_logo dScnLogo_c::~dScnLogo_c() +1 93.19% 93.20%
framework/d/d_s_play dScnPly_Delete(dScnPly_c*) +1 93.61% 93.65%
framework/m_Do/m_Do_main main01() 0 22.62% 22.63%
framework/m_Do/m_Do_graphic mDoGph_Painter() 0 97.76% 97.76%
framework/d/d_s_logo dScnLogo_c::create() 0 99.78% 99.95%

Report for GZ2P01 (3f24f43 - 54a5eb7)

No changes

Report for GZ2E01 (3f24f43 - 54a5eb7)

No changes

@caseif caseif changed the title Link d_csr_mng for all Wii versions Link d_cursor_mng for all Wii versions May 24, 2026

@TakaRikka TakaRikka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once conflicts are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants