Refactor: Dedicated checkpoint contest test group - #3689
B4S1C-Coder wants to merge 5 commits into
Conversation
|
There is a CI error in the Basic Checks, so please fix it. |
b167d56 to
4b2d3ca
Compare
|
I fixed the error in basic check and completed the DCO check. Just curious, is it possible for me to run these checks on my own fork as well? To avoid such issues in future. |
Signed-off-by: B4S1C-Coder <saksham2005mittal@gmail.com>
Signed-off-by: B4S1C-Coder <saksham2005mittal@gmail.com>
Signed-off-by: B4S1C-Coder <saksham2005mittal@gmail.com>
4b2d3ca to
0d1a314
Compare
|
@saku3 I resolved the merge conflicts. Please do let me know if anything is to be done from my end. |
Signed-off-by: B4S1C-Coder <saksham2005mittal@gmail.com>
263d264 to
0d61def
Compare
|
@saku3 just checking in on this, all the tests are passing. Let me know if anything else is needed to be done from my end. Thanks! |
nayuta723
left a comment
There was a problem hiding this comment.
I left a nit comment. Please review the current main branch again and minimize the differences.
|
|
||
| fn bring_up_loopback(project_path: &Path, id: &str) -> Result<(), TestResult> { | ||
| // CRIU requires a minimal network setup in the network namespace | ||
| fn setup_network_namespace(project_path: &Path, id: &str) -> Result<(), TestResult> { |
There was a problem hiding this comment.
There is a significant difference in the bring_up_loopback implementation. Please align it with the current main branch, unless there was a specific reason for the changes.
There was a problem hiding this comment.
Hi, thanks for having a look.
-
The
setup_network_namespacedid not have theoutput.status.success()check. I have added this check, so now ifip link set up dev lofailed, it would get caught. -
checkpoint()was unconditionally callingsetup_network_namespaceon every checkpoint test (Now it does not do that, aliging with main branch).
PS. I used the name setup_network_namespace instead of bring_up_loopback because it felt more accurate, I can revert it if needed to match main exactly.
Signed-off-by: B4S1C-Coder <saksham2005mittal@gmail.com>
|
While rebasing I noticed that #3700 already wired checkpoint tests (leave-running, cgroup modes, link-remap, tcp-skip-in-flight, external namespaces) directly into Given this overlap, I don't think it makes sense for me to push this forward right now. I'd be stepping on on-going work. I'm going to step back from this PR. Feel free to close it, or let me know if you'd still like the dedicated |
Description
Added a dedicated
checkpointcontest test group and moved checkpoint-only tests out oflifecycle.The new group owns its container setup and cleanup through RAII context.
checkpoint-restorehas remain unchanged.Type of Change
Testing
Manual Validation
just contest-listand verifiedcheckpoint existsjust test-content lifecyclebefore the cleanup tp compare the existing checkpoint behaviour.Related Issues
Fixes #3641
Additional Context
The
checkpointgroup is sequential because CRIU checkpoint operations use global kernel resources and can interfere with one another.