Skip to content

chore(deps): bump nix from 0.29.0 to 0.31.3 - #3628

Merged
saku3 merged 1 commit into
youki-dev:mainfrom
daschinmoy21:nix-bump
Sep 10, 2026
Merged

saku3 merged 1 commit into
youki-dev:mainfrom
daschinmoy21:nix-bump

Conversation

@daschinmoy21

@daschinmoy21 daschinmoy21 commented Jun 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Bump nix crate to latest version and update codebase to fix all breaking changes

  • open() and similar calls now return OwnedFd instead of RawFd;
    use .as_raw_fd() where a raw fd is still needed
  • fcntl::fcntl() now takes &Fd instead of RawFd; use
    BorrowedFd::borrow_raw() for raw fd values and &fd for owned fds

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

Fixes #3622

Additional Context

Signed-off-by: Chinmoy daschinmoyy21@gmail.com

@daschinmoy21
daschinmoy21 force-pushed the nix-bump branch 2 times, most recently from bade954 to 6a5843f Compare June 29, 2026 10:21
@saku3 saku3 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 29, 2026
@daschinmoy21
daschinmoy21 force-pushed the nix-bump branch 3 times, most recently from a7311e9 to ba11d1b Compare June 30, 2026 12:38
@daschinmoy21

Copy link
Copy Markdown
Contributor Author

pinging for CI apporval

@daschinmoy21

Copy link
Copy Markdown
Contributor Author

fixed failing ci test should be good to go

@daschinmoy21

Copy link
Copy Markdown
Contributor Author

Pinging for review

@saku3 saku3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review.

I've left some comments, so please take a look when you have time.

Comment thread crates/libcontainer/src/syscall/linux.rs Outdated
Comment thread crates/libcontainer/src/syscall/linux.rs Outdated
Comment thread crates/libcontainer/src/namespaces.rs Outdated
Comment thread crates/libcontainer/src/tty.rs Outdated
Comment thread crates/libcontainer/src/process/init/process.rs Outdated
Comment thread tests/contest/contest/src/tests/fd_control/mod.rs Outdated
@daschinmoy21
daschinmoy21 force-pushed the nix-bump branch 2 times, most recently from 6f27aa4 to 8c1a601 Compare August 9, 2026 12:04
@daschinmoy21

Copy link
Copy Markdown
Contributor Author

Addressed feedback. Also squashed commits. Should be good to go

@saku3

saku3 commented Aug 13, 2026

Copy link
Copy Markdown
Member

Could you please fix the CI errors?

@daschinmoy21
daschinmoy21 force-pushed the nix-bump branch 2 times, most recently from 2f2eba8 to 54f0c06 Compare August 19, 2026 15:37
@daschinmoy21

Copy link
Copy Markdown
Contributor Author

updated cicd should pass

@saku3

saku3 commented Aug 30, 2026

Copy link
Copy Markdown
Member

@daschinmoy21

Sorry, but could you please resolve the conflicts?

@daschinmoy21

Copy link
Copy Markdown
Contributor Author

Conflicts resolved, should be good to go

Signed-off-by: Chinmoy <daschinmoyy21@gmail.com>

@saku3 saku3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@saku3
saku3 merged commit 7d3bbd3 into youki-dev:main Sep 10, 2026
30 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update nix crate

2 participants