Skip to content

Update youki name explanation in index.html - #3510

Closed
coderaiser wants to merge 1 commit into
youki-dev:gh-pagesfrom
coderaiser:patch-2
Closed

coderaiser wants to merge 1 commit into
youki-dev:gh-pagesfrom
coderaiser:patch-2

Conversation

@coderaiser

Copy link
Copy Markdown

Description

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

Fixes #

Additional Context

@nayuta723

Copy link
Copy Markdown
Contributor

Could you check DCO?

Signed-off-by: coderaiser <coderaiser@cloudcmd.io>
@coderaiser

Copy link
Copy Markdown
Author

Sure

@nayuta723 nayuta723 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saku3

saku3 commented Apr 25, 2026

Copy link
Copy Markdown
Member

I think it would be better to handle this together with the related PRs below, rather than addressing it separately.

#3472

@utam0k

utam0k commented Apr 25, 2026

Copy link
Copy Markdown
Member

I think it would be better to handle this together with the related PRs below, rather than addressing it separately.

#3472

+1

@coderaiser

Copy link
Copy Markdown
Author

As I understand gh-pages is deployment branch of a website and previous MR related to main branch of development. Do you have source files of a web site in your main branch?

@saku3

saku3 commented Apr 25, 2026 •

Copy link
Copy Markdown
Member

The file below is the relevant one 🙏

youki is pronounced as /joʊki/ or yoh-key.

The page at https://youki-dev.github.io/youki/ is built with mdBook from the main branch and then deployed to GitHub Pages. So I think the relevant source files are on main, not on gh-pages.

https://github.com/youki-dev/youki/blob/main/.github/workflows/docs.yaml

@coderaiser

Copy link
Copy Markdown
Author

Just updated

@saku3

saku3 commented Apr 25, 2026

Copy link
Copy Markdown
Member

Thanks.

I will close this PR.

@saku3 saku3 closed this Apr 25, 2026
@coderaiser
coderaiser deleted the patch-2 branch April 25, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants