Skip to content

fix: make telemetry optional - #14

Merged
antirotor merged 8 commits into
developfrom
enhancement/make-otel-optional
Oct 1, 2026
Merged

antirotor merged 8 commits into
developfrom
enhancement/make-otel-optional

Conversation

@antirotor

Copy link
Copy Markdown
Member

Changelog Description

Make the opentelemetry in image optional.

Additional review information

OpenTelemetry in docker image was enabled by default, this is making it optional (disabled by default). It can be enabled using AYON_MCP_OTEL_ENABLED

@antirotor antirotor self-assigned this Oct 1, 2026
Copilot AI balanced review requested due to automatic review settings October 1, 2026 17:23
@antirotor antirotor added the type: enhancement Improvement of existing functionality or minor addition label Oct 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The Compose deployment still requires the external observability network when telemetry is disabled, and the new conditional behavior lacks tests.

Review effort: Balanced
Findings: 1 High severity · 2 Low severity

Open (3)
What changed in this PR

Makes OpenTelemetry opt-in for the Dockerized MCP service.

Changes:

  • Adds the AYON_MCP_OTEL_ENABLED flag.
  • Conditionally enables instrumentation and token metrics.
  • Aligns the service image tag with the add-on version.
File Description
services/​mcp/​Dockerfile Selects instrumented or standard startup.
services/​mcp/​docker-compose.yml Adds the telemetry flag.
services/​mcp/​ayon_mcp/​server.py Conditionally registers metrics middleware.
README.md Documents telemetry configuration.
package.py Updates image tagging and telemetry defaults.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread services/mcp/docker-compose.yml
Comment thread README.md
Comment thread services/mcp/ayon_mcp/server.py
antirotor and others added 2 commits October 1, 2026 19:27
Co-authored-by: antirotor <33513211+antirotor@users.noreply.github.com>
@antirotor antirotor changed the title feat(telemetry): make telemetry optional fix: make telemetry optional Oct 1, 2026
@antirotor
antirotor merged commit b0607df into develop Oct 1, 2026
4 checks passed
@antirotor
antirotor deleted the enhancement/make-otel-optional branch October 1, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants