Skip to content

Reuse the shared composer for inbox replies - #1248

Merged
16francej merged 5 commits into
fix/inbox-conversation-draftfrom
fix/inbox-shared-composer
Sep 15, 2026
Merged

16francej merged 5 commits into
fix/inbox-conversation-draftfrom
fix/inbox-shared-composer

Conversation

@16francej

Copy link
Copy Markdown
Contributor

Summary

  • Reuse the shared composer beneath each inbox thread, including attachments, model, effort, and fast mode.
  • Keep runtime choices local to the inbox conversation and preserve draft-version checks.
  • Keep “Send it” distinct and left-aligned, with edit suggestions centered and Dismiss outside the composer.

Stacked on #1078 so this diff contains only the composer and layout changes.

Verification

  • 82 frontend tests, 81 backend tests, and a model-authorization integration test passed locally.
  • Typechecks, lint, formatting, knip, and production build passed.
  • Browser checks at 1440, 780, 390, and 320px; attachment uploads, stale drafts, failed submissions, and runtime isolation tested with synthetic responses.
  • Latest alignment change: 25 targeted tests and responsive browser checks passed.

No real provider sends or deployed end-to-end test performed.

@16francej
16francej merged commit bac3e12 into fix/inbox-conversation-draft Sep 15, 2026
16 checks passed
@16francej
16francej deleted the fix/inbox-shared-composer branch September 15, 2026 23:59
16francej added a commit that referenced this pull request Sep 24, 2026
* Separate inbox send suggestions from item dismissal

* Place inbox replies directly beneath the source thread

* Reuse the shared composer for inbox followups

* Left-align the inbox send suggestion

* Fix inbox conversation fixtures and pin pooling CI actions

---------
16francej added a commit that referenced this pull request Sep 25, 2026
* Unify inbox drafts with conversation and submit send as a prompt

* Reconcile external inbox replies and anchor Slack source threads

* Reuse the shared composer for inbox replies (#1248)

* Separate inbox send suggestions from item dismissal

* Place inbox replies directly beneath the source thread

* Reuse the shared composer for inbox followups

* Left-align the inbox send suggestion

* Fix inbox conversation fixtures and pin pooling CI actions

---------

* Preserve current inbox flows and runtime isolation after rebase

* Freeze inbox draft approval before attachment upload

* Give phone inbox instructions a full composer row

* Simplify inbox submission, validation and test setup

---------

Co-authored-by: QM <josh@ycombinator.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant