Skip to content

Improve for requirejs#35

Open
sielay wants to merge 1 commit into
yabwe:masterfrom
sielay:master
Open

Improve for requirejs#35
sielay wants to merge 1 commit into
yabwe:masterfrom
sielay:master

Conversation

@sielay

@sielay sielay commented Sep 26, 2016

Copy link
Copy Markdown

Your UMD won't work with requirejs, as you expect MediumEditor to be globally available and use use strict in the same mode and then invoke your factory without reference to root.

My change will be breaking so wroth making major version.

In case of requirejs usage you'd have to inject MediumEditor like

MeTables = require('medium-editor-tables')({
        MediumEditor: MediumEditor
    });

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 10.821% when pulling 77310ad on sielay:master into fe1e313 on yabwe:master.

@nmielnik

nmielnik commented Feb 8, 2017

Copy link
Copy Markdown
Member

@sielay or @yazonnile any chance you could try to fix the merge conflict and push this up again? We'll be sure to get this merged quickly this time, we've been on a bit of a hiatus for a while

@jmsunseri

jmsunseri commented May 17, 2019

Copy link
Copy Markdown

I could really use this. I'm trying to use in an angular project and it's just not going to work as coded I don't think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants