Rename 'Unknown0' field to 'Radius' in ModelChara#230
Open
Makar8000 wants to merge 1 commit into
Open
Conversation
Contributor
✅ Validation succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If present (not 0), the value in this field appears to be multiplied by BNpcBase.Scale to determine HitboxRadius for BNpcs. Otherwise (if 0), ModelSkeleton.Radius seems to be used instead. The result will be stored in FFXIVClientStructs.FFXIV.Client.Game.Character.ModelContainer.UnscaledRadius
It's also referenced in
Client::Game::Character::ModelContainer::CalculateUnscaledRadiusExamples below
Kefka (DMU P2 version)
Kefka (DMU P2 version)
In-game hitbox radius: 6.02
https://exd.camora.dev/sheet/BNpcBase#R19506
Scale: 3.5
https://exd.camora.dev/sheet/ModelChara#R4967
Radius: 1.72
Model: 459
https://exd.camora.dev/sheet/ModelSkeleton#R459
Radius: 1
3.5 * 1.72 = 6.02
Exdeath (DMU P3 version)
Exdeath (DMU P3 version)
In-game hitbox radius: 3.8
https://exd.camora.dev/sheet/BNpcBase#R19509
Scale: 3.8
https://exd.camora.dev/sheet/ModelChara#R326
Radius: 0
Model: 109
https://exd.camora.dev/sheet/ModelSkeleton#R109
Radius: 1
3.8 * 1 = 3.8
Chaos (DMU P3 version)
Chaos (DMU P3 version)
In-game hitbox radius: 6
https://exd.camora.dev/sheet/BNpcBase#R19508
Scale: 1
https://exd.camora.dev/sheet/ModelChara#R5010
Radius: 6
Model: 295
https://exd.camora.dev/sheet/ModelSkeleton#R295
Radius: 4.5
1 * 6 = 6
Hephaistos (P8N)
Hephaistos (P8N)
In-game hitbox radius: 10
https://exd.camora.dev/sheet/BNpcBase#R15045
Scale: 0.8
https://exd.camora.dev/sheet/ModelChara#R3621
Radius: 0
Model: 790
https://exd.camora.dev/sheet/ModelSkeleton#R790
Radius: 12.5
0.8 * 12.5 = 10