CI-fixes PR #1: pyright is ready to replace pyre - #147
Merged
Conversation
CI PR #2: Fix GitHub CI and add checks to compensate for code coverageCI PR #5: Fix GitHub CI and add checks to compensate for code coverage
Pull Request Test Coverage Report for Build 11861101564Details
💛 - Coveralls |
CI PR #5: Fix GitHub CI and add checks to compensate for code coverageCI PR #5: Complete the transition from pyre to pyright
bernhardkaindl
force-pushed
the
ci-finnish-pyre-enforce-pyright
branch
from
November 15, 2024 17:56
2601fd1 to
88ad644
Compare
This was referenced Nov 15, 2024
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
ci-finnish-pyre-enforce-pyright
branch
from
August 15, 2025 10:01
88ad644 to
b575246
Compare
CI PR #5: Complete the transition from pyre to pyrightpyre to pyright
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
pyre to pyrightpyright is ready to replace pyre (obsolete)
bernhardkaindl
requested review from
chunjiez and
rosslagerwall
and removed request for
freddy77
August 15, 2025 11:07
pyright is ready to replace pyre (obsolete)pyright is ready to replace pyre
rosslagerwall
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now,
pyrightis ready to replacepyre(obsolete):The short summary is:
Full summary:
pyright(Python analsyis server of VS Code)pyre(Facebook's Python static analysis tool):As pyre is inferior in every aspect, replace it with Pyright (already used in pre-commit):
tox.ini: Complete the transition frompyretopyrightpre-commit: Remove the remaining call topyreinpre-commitdocs: Complete the transition frompyretopyrighttox.ini/pyright: Fail tox ifpyrightfails (enforce check)pyre-errorsuppressions