CP-313559 Support grub-mkconfig action in installer (test only) - #337
CP-313559 Support grub-mkconfig action in installer (test only)#337TimSmithCtx wants to merge 1 commit into
Conversation
Provide for a transition to using grub-mkconfig for generating the bootloader configuration by writing information required for an update-grub action into a configuration file and invoking it, but only if the install actually has the update-grub action. The update-grub action is expected to honor XS__GRUB_TEST_ONLY and write only a test configuration. A later change will detect that the install does not want test mode, and both leave out the XS__GRUB_TEST_ONLY setting, and avoid writing the legacy bootloader configuration, expecting the update-grub action to have done it for real. Signed-off-by: Tim Smith <tim.smith@citrix.com>
GeraldEV
left a comment
GeraldEV
left a comment
There was a problem hiding this comment.
Looks good, I had one or two minor comments but I think they're all just artifacts of the old implementation and mostly non-functional so I'll do them myself in another PR at some point
Only question is; is there a better phrasing of "safe mode"? I know your comment explains the difference but it won't be explained in the xs_settings file
I'm open to suggestions. I inherited the terminology from a starting point which pre-dated the removal of safe mode and just kept it because I couldn't think of a replacement which worked. Possibly the correct place to expand on this would be the grub-mkconfig fragment which handles the contents of the xs_settings file? |
2 participants
Provide for a transition to using grub-mkconfig for generating the bootloader configuration by writing information required for an update-grub action into a configuration file and invoking it, but only if the install actually has the update-grub action.
The update-grub action is expected to honor XS__GRUB_TEST_ONLY and write only a test configuration.
A later change will detect that the install does not want test mode, and both leave out the XS__GRUB_TEST_ONLY setting, and avoid writing the legacy bootloader configuration, expecting the update-grub action to have done it for real.