CA-430573: Use int64 in Go SDK - #7232
Open
xueqingz wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
SDK test pass on XenRT job 4718034, 4718035. |
Signed-off-by: Sola.Zhang <Sola.Zhang@cloud.com>
xueqingz
force-pushed
the
private/xueqingz/CA-430573
branch
from
August 20, 2026 06:26
cb43a3f to
7c325ed
Compare
kc284
reviewed
Aug 20, 2026
| return | ||
| } | ||
| strValue := fmt.Sprintf("%v", input) | ||
| floatValue, err := strconv.ParseFloat(strValue, 64) |
Contributor
There was a problem hiding this comment.
Since we want an int64 in line 55, should we have first tried to use ParseInt here and then ParseFloat only if the former fails?
kc284
reviewed
Aug 20, 2026
| return | ||
| } | ||
| strValue := fmt.Sprintf("%v", input) | ||
| floatValue, err := strconv.ParseFloat(strValue, 64) |
Contributor
There was a problem hiding this comment.
Same question as in ConvertTime.mustache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.