Skip to content

Upgrade to .NET 10, update dependencies, and clean up solution#2

Open
Jaredl-Dev wants to merge 4 commits into
x64-dev:masterfrom
Jaredl-Dev:master
Open

Upgrade to .NET 10, update dependencies, and clean up solution#2
Jaredl-Dev wants to merge 4 commits into
x64-dev:masterfrom
Jaredl-Dev:master

Conversation

@Jaredl-Dev
Copy link
Copy Markdown

@Jaredl-Dev Jaredl-Dev commented May 15, 2026

This pull request does several things:

  • Upgrades to target .NET 10 and C# 14.
  • Sets up single file publishing.
  • Moves app versioning to SDK project metadata as the single source of truth and sets the current SemVer version to 1.0.0.
  • Removes the launcher self-updater flow, update notification dialog, update manifest handling, and related localized strings.
  • Updates dependencies to current stable versions.
  • Updates Minio/S3 code for the newer client API while keeping existing mod manifests working.
  • Removes obsolete .NET Framework-era files and setup.
  • Removes unused configurations, dead code, stale generated files, old checked-in DLLs, and vendored package folders.
  • Removes unused usings, correct namespaces, and reformats/reorganizes code in the solution.
  • Fixes build warnings from unsupported legacy project settings.

Why the self-updater was removed: this project is a fork. If the upstream self-updater stayed enabled and upstream published a newer version, it could replace this forked executable with the upstream build and overwrite this fork's behavior.

Note: This PR removes a large amount of code/files. Git shows roughly 147,598 lines removed, mostly from old vendored packages, checked-in dependency binaries, generated artifacts, cache files, and dead/unused files.

See the individual commits for more details on the specific changes.

@Jaredl-Dev Jaredl-Dev marked this pull request as draft May 18, 2026 03:34
@Jaredl-Dev Jaredl-Dev changed the title Target .NET Framework 4.8.1, Update Dependencies, Fix Mod Downloading, Disable Obsolete Features, and Update Discord Link Modernize GenLauncher for GeneralsOnline (DO NOT MERGE YET) May 18, 2026
@Jaredl-Dev Jaredl-Dev force-pushed the master branch 5 times, most recently from a7b48c1 to 5232788 Compare May 19, 2026 06:18
@Jaredl-Dev Jaredl-Dev changed the title Modernize GenLauncher for GeneralsOnline (DO NOT MERGE YET) Target .NET Framework 4.8.1, update dependencies, and remove unused code, dependencies, and files throughout the codebase. May 19, 2026
@Jaredl-Dev Jaredl-Dev marked this pull request as ready for review May 19, 2026 06:33
@Jaredl-Dev Jaredl-Dev changed the title Target .NET Framework 4.8.1, update dependencies, and remove unused code, dependencies, and files throughout the codebase. Target .NET Framework 4.8.1, update dependencies, and remove unused code, dependencies, and files, cleanup May 19, 2026
@Jaredl-Dev Jaredl-Dev changed the title Target .NET Framework 4.8.1, update dependencies, and remove unused code, dependencies, and files, cleanup Target .NET Framework 4.8.1, update dependencies, and remove unused code, dependencies, and files, formatting May 19, 2026
@Jaredl-Dev Jaredl-Dev changed the title Target .NET Framework 4.8.1, update dependencies, and remove unused code, dependencies, and files, formatting Target .NET Framework 4.8.1, update dependencies, and remove unused code, dependencies, and files, formatting, namespace correction May 19, 2026
@Jaredl-Dev Jaredl-Dev changed the title Target .NET Framework 4.8.1, update dependencies, and remove unused code, dependencies, and files, formatting, namespace correction Target .NET Framework 4.8.1, update dependencies, remove unused code/files, formatting, and fix namespaces. May 19, 2026
@Jaredl-Dev Jaredl-Dev force-pushed the master branch 2 times, most recently from fc46184 to 5277933 Compare May 19, 2026 18:58
@Jaredl-Dev Jaredl-Dev changed the title Target .NET Framework 4.8.1, update dependencies, remove unused code/files, formatting, and fix namespaces. Target .NET Framework 4.8.1, update dependencies, remove unused code/files, formatting, fix namespaces and overhaul readme. May 19, 2026
@Jaredl-Dev Jaredl-Dev changed the title Target .NET Framework 4.8.1, update dependencies, remove unused code/files, formatting, fix namespaces and overhaul readme. Target .NET Framework 4.8.1, update dependencies, remove unused or redundent code/files, formatting, fix namespaces, overhaul readme, fixed unreachable code. May 19, 2026
@Jaredl-Dev Jaredl-Dev changed the title Target .NET Framework 4.8.1, update dependencies, remove unused or redundent code/files, formatting, fix namespaces, overhaul readme, fixed unreachable code. Target .NET 10, update dependencies, and clean up legacy files May 20, 2026
@Jaredl-Dev Jaredl-Dev changed the title Target .NET 10, update dependencies, and clean up legacy files Upgrade to .NET 10, update dependencies, and clean up solution May 20, 2026
@Jaredl-Dev Jaredl-Dev marked this pull request as draft May 20, 2026 02:00
Migrate the WPF launcher project to SDK-style .NET 10 with C# 14, win-x64 targeting, and compressed self-contained single-file publishing.

Update NuGet references to current stable versions, adapt Minio usage to the v7 client API, and replace obsolete framework-era code paths such as legacy TLS setup, .NET Framework startup config, SymbolicLinkSupport usage, and Prefer32Bit settings.

Remove unused configurations, old packages.config/Fody artifacts, checked-in legacy package binaries, stale generated resources/settings, unused source files, and other dead repository artifacts identified during the audit. This cleanup removes roughly 147,598 lines from the repository, mostly legacy package cache files, checked-in binaries, generated artifacts, and dead code.

Verified Debug and Release builds with zero warnings, checked package outdated/deprecated/vulnerable status, and confirmed Release publish emits a single GenLauncher.exe.
Remove the app self-updater flow, update notification dialog, and related launcher update manifest handling.

This fork should not allow the upstream self-updater to replace the forked executable with a newer upstream build, because that could overwrite this fork's changes.

Move the displayed app version to SDK project metadata as the single source of truth and mark the disabled update button as Up to Date.
@Jaredl-Dev Jaredl-Dev marked this pull request as ready for review May 20, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant