Repository navigation
fix(store): hide packages by org/name, exclude them from the sitemap and return not found on their pages - #62
Merged
daneshk merged 3 commits intoOct 6, 2026
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
daneshk
approved these changes
Oct 6, 2026
11 of 32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hidden packages were only filtered from the listing and search. This makes the hidden list apply
everywhere, and lets entries target one organization.
HIDDEN_PACKAGESentries can now be a bare name (every org) ororg/name(one org).Type of Change
Related Issue(s)
Relates to wso2/product-integrator#2639 (items 2 and 4)
Changes Made
hidden-packages.json(same 82 entries, unchanged) becausescripts/generate-sitemap.jsis plain Node and cannot import TypeScript.
HIDDEN_PACKAGESis still a mutableSetbuilt from it.isHiddenPackage(pkg)matches a bare name ororg/name.rest-client.tsuses it at all three placesthat used
HIDDEN_PACKAGES.has(pkg.name).organizationis added to theBallerinaPackagetype; the APIalready returns it.
generate-sitemap.jsreads the same JSON and skips hidden packages. Added arequire.mainguard andexports so it can be unit-tested; behavior as a plain script is unchanged.
ConnectorDetailPage.tsx: for a hidden package it skips all fetching and shows "Connector not found"with a "Back to store" button (no Retry).
hidden-packages.mddescribes the list format.isHiddenPackage, a dual-org case inrest-client.test.ts, sitemap exclusion, and a newConnectorDetailPage.test.tsx.npstill hides bothballerina/npandballerinax/np, as agreed. Use anorg/npentry to hide only one.Testing Performed
Test Environment
Test Cases
Unit tests pass (
npm test)Integration tests pass (if applicable)
Manual testing completed
Tested on mobile devices
Tested on desktop browsers
8 suites, 114 tests pass on this branch.
node scripts/generate-sitemap.jsagainst the live Ballerina Central API: 755 URLs (836 before), with noballerina/sqlornpin the output.npm run buildalso compiles with the prebuild step.Browser:
/connector/ballerina/sql/latestshows "Connector not found";/connector/ballerinax/kafka/latestloads normally.
Mutation check: a name-only
isHiddenPackagemakes the org tests fail.Screenshots
Before
/connector/ballerina/sql/latestrenders a full detail page.After
<attach the "Connector not found" screenshot>
Code Quality Checklist
npm run lintpasses)npm run format:checkpasses)npx tsc --noEmit)Documentation
Performance Impact
Details:
Breaking Changes
Details:
Additional Notes
index.html(_redirects), so the HTTPstatus is still 200. A real 404 would need a hosting change.
name-versionand ignores the org,so if two orgs ever publish the same name at the same version one would be dropped before the hidden check.
It doesn't affect today's data.