Document Redis Configuration and Scope/Operation Behavior During API Import - #11760
Conversation
📝 WalkthroughSummary
WalkthroughThe changes add Redis connection and Jedis pool settings to the API-M configuration catalog and document their use for distributed or hybrid throttling. The documentation covers timeouts, TLS, gateway identity, pool limits, and wait behavior. API import guides now state that scopes and operations must be defined in the API definition file because values placed only in Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@en/docs/api-gateway/rate-limiting/configuring-rate-limiting-api-gateway-cluster.md`:
- Around line 158-161: Update the pool_options.max_wait_millis row in the
configuration table to mark the parameter as Optional instead of Mandatory,
retaining the existing default of -1 and the production warning unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f223c82a-6a07-4b07-a6ba-73a63715567a
📒 Files selected for processing (7)
en/docs/api-gateway/rate-limiting/configuring-rate-limiting-api-gateway-cluster.mden/docs/apiops/cli/managing-apis-api-products/importing-apis-via-dev-first-approach.mden/docs/apiops/cli/managing-apis-api-products/migrating-apis-to-different-environments.mden/docs/reference/config-catalog.mden/tools/config-catalog-generator/data/apim.redis_config.pool_options.tomlen/tools/config-catalog-generator/data/apim.redis_config.tomlen/tools/config-catalog-generator/data/configs.json
|
+1 for the APICTL related doc changes |
This pull request introduces comprehensive documentation and configuration updates for Redis-backed distributed throttling in the API Gateway, including new configuration examples, catalog entries, and important clarifications for API import behavior. The main changes are grouped below.
Redis Throttling Configuration Documentation and Examples:
connection_timeout,socket_timeout,ssl, andpool_options.max_wait_millis) in the API Gateway rate limiting guide, including warnings about safe production values.apim.redis_config.tomlfor Redis connection settings andapim.redis_config.pool_options.tomlfor connection pool tuning. [1] [2]Configuration Catalog Enhancements:
configs.jsonto include the new Redis configuration sections with detailed parameter descriptions and linked example files, improving discoverability and usability for users configuring distributed throttling.API Import Behavior Clarifications:
api.yaml, or they will be silently dropped during import. [1] [2]Related Issues