Skip to content

Bug fix in UDM MP - #2365

Open
Songyou184 wants to merge 2 commits into
wrf-model:release-v4.8.1from
Songyou184:WDM7-4.8.1
Open

Bug fix in UDM MP#2365
Songyou184 wants to merge 2 commits into
wrf-model:release-v4.8.1from
Songyou184:WDM7-4.8.1

Conversation

@Songyou184

Copy link
Copy Markdown
Contributor

The first line should be a single-line "purpose" for this change

TYPE: Bug fix

KEYWORDS: Prevent artificial rain accumulation

SOURCE: songyou hong

DESCRIPTION OF CHANGES:
Problem:
UDM MP occasionally produces unphysical rain activities

Solution:
Allow tiny values of rain drops (qr < 1.e-9) to be sedimented

LIST OF MODIFIED FILES: module_mp_udm.F

TESTS CONDUCTED:

  1. Ming Chen confirmed that this PR fixes the issue in 4.8 UDM MP
  2. Are the Jenkins tests all passing?

RELEASE NOTE:

@Songyou184
Songyou184 requested a review from a team as a code owner July 13, 2026 22:19
@weiwangncar

Copy link
Copy Markdown
Collaborator

The regression results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@dudhia

dudhia commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

This should be targeted for develop.
The change in WDM7 includes the change for UDM, so it should go in after this one.

@weiwangncar
weiwangncar changed the base branch from master to develop July 27, 2026 17:27
@weiwangncar
weiwangncar changed the base branch from develop to release-v4.8.1 July 27, 2026 19:37
@weiwangncar

Copy link
Copy Markdown
Collaborator

This needs to be merged before PR-2366.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants