fix: verify SCA signatures on signed chain#32
Open
andy-t-wang wants to merge 1 commit into
Open
Conversation
andy-t-wang
requested review from
Takaros999,
m1guelpf and
paolodamico
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCA verification now follows the EVM chain in the signed AgentKit payload. A Base smart-account signature can be verified against Base, then the same address is checked in the canonical World Chain AgentBook registry.
This keeps AgentBook lookup chain-stable while allowing servers to accept smart-account signatures from contracts deployed on other EVM chains. Integrators can configure
rpcUrlsby CAIP-2 chain ID, with the existingrpcUrloption preserved as a fallback.Testing
bun test core/tests/verify.test.tsbun test x402/tests/hooks.test.tsbun run build:corebun run build:x402