Repository navigation
fix(auth): stop the after-hook from clobbering every response with null - #422
Merged
Merged
Conversation
better-auth's dispatcher only treats a hook's `response` as an override
when it is `!== undefined` (better-auth/dist/api/dispatch.mjs) -- `null`
counts as a real override, not a no-op. This hook only has side effects
to run (JIT provisioning on sign-up) and returned `{ response: null,
headers: null }` for every other path as its "nothing to do" signal,
which wiped the real response of every other better-auth endpoint --
including /sign-in/email and /get-session -- to literal null.
Fix: return nothing instead of `{ response: null }` for the no-op
paths, leaving the dispatcher's original response untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
better-auth's dispatcher only treats a hook's
responseas an override when it is!== undefined(better-auth/dist/api/dispatch.mjs) --nullcounts as a real override, not a no-op. This hook only has side effects to run (JIT provisioning on sign-up) and returned{ response: null, headers: null }for every other path as its "nothing to do" signal, which wiped the real response of every other better-auth endpoint -- including /sign-in/email and /get-session -- to literal null.Fix: return nothing instead of
{ response: null }for the no-op paths, leaving the dispatcher's original response untouched.Summary
Related issues
How to test
Checklist
pnpm typecheckpasses.pnpm lintpasses.pnpm testpasses.