Add SwiftFormat check to CI - #129
Merged
Merged
Conversation
Add a Format job that runs `swiftformat --lint PagerCall`, matching the Slackpad CI setup. Also apply the formatting fixes so the check passes (trailing comma, redundant memberwise initializers). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KvQ1BLHNVbshkwL2qTosFa
SwiftFormat's trailingCommas rule adds trailing commas, which conflicts with SwiftLint's default trailing_comma rule. Set mandatory_comma so both tools agree, matching the Slackpad setup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KvQ1BLHNVbshkwL2qTosFa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slackpad の CI に倣って、
swiftformat --lint PagerCallを実行するFormatジョブを追加しました（macos-latest+brew install swiftformat）。あわせて、チェックを通すためのフォーマット修正を適用しています（SwiftFormat 0.62.1）:
PagerDutyAPI.swift: 末尾カンマの追加PreActionButtonStyle.swift: 冗長なメモリワイズ init の削除🤖 Generated with Claude Code