Repository navigation
docs: align CONTRIBUTING Node/pnpm versions with package engines - #5231
Closed
imitater-dou wants to merge 1 commit into
Closed
imitater-dou wants to merge 1 commit into
imitater-dou wants to merge 1 commit into
Conversation
Update prerequisite versions in CONTRIBUTING.md to match package.json engines.node (>=24.5), packageManager (pnpm@11.13.1), and the install-dependencies action (node-version 24.5). Signed-off-by: ADou <ikun3.1415927@gmail.com>
|
@imitater-dou is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/CONTRIBUTING.mdstill tells contributors to install Node.js v22 and pnpm v9.1.0, but the repo already requires newer tooling.Repro / evidence (current
main).github/CONTRIBUTING.mdpackage.jsonengines.node>=24.5package.jsonpackageManagerpnpm@11.13.1.github/actions/install-dependencies/action.ymlnode-version: 24.5Change
Update the CONTRIBUTING prerequisite line to Node.js v24.5 or higher and pnpm v11 or higher so it matches
package.jsonand CI install action.Why
New contributors following CONTRIBUTING alone can install Node 22 / pnpm 9 and still fail
engines/packageManagerchecks.