feat(tempo): restore MACH funding routes - #869
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e25bb47706
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
parvahuja
changed the title
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| }, | ||
| })) ?? defaultAccount | ||
|
|
||
| const machineTokenCandidate = machineTokenEnabled |
There was a problem hiding this comment.
i don't love us just inlining a big block here with a conditional, but I think this is fine in the short term since we can collapse later
| import * as defaults from './defaults.js' | ||
|
|
||
| const swapAbi = [ | ||
| { |
There was a problem hiding this comment.
is this a custom ABI? or can we pull this from the upstream viem types?
There was a problem hiding this comment.
lts custom, but i can clean this up a bit of the redudancy here
| } | ||
| } | ||
|
|
||
| function authorizationDomain(router: Address, chainId: number) { |
There was a problem hiding this comment.
we still don't support sessions on mainnet right? so this is just landing ahead of then?
There was a problem hiding this comment.
we actually do support session via the swapper based of our original design -- it gets around the TIP1034 "refund" issue by burning the and reminting back to the user
| const res = await fetch('https://mpp.dev/api/ping/paid') | ||
| ``` | ||
|
|
||
| Servers price payments in PathUSD, USDC.e, or another supported settlement token. When a server |
571dd23 to
dc318a9
Compare
2 participants
Why
Allow mppx clients holding MACH to fund payments without merchants advertising or accepting MACH directly.
What
machineTokenEnabledin authenticated method details while preserving the advertised settlement currency and recipient.