Skip to content

fix(tempo): preserve dispatched session vouchers - #827

Open
parvahuja wants to merge 1 commit into
mainfrom
parv/fix-session-response-recovery
Open

parvahuja wants to merge 1 commit into
mainfrom
parv/fix-session-response-recovery

Conversation

@parvahuja

@parvahuja parvahuja commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Why

A session voucher may reach the server even when the client never receives a response. Rolling back that voucher can make the client reuse an already-authorized cumulative amount and diverge from the server.

What

  • Classify a credential fetch that throws after handoff as an unknown outcome.
  • Stage session vouchers and commit them only when accepted or when delivery is unknown; discard them on known rejection or pre-dispatch abort.
  • Keep SessionManager focused on durable channel checkpoints, with small regressions for active and resumed channels.

@pkg-pr-new

pkg-pr-new Bot commented Aug 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/mppx@827

commit: 38e3bbd

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c804a30c4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/tempo/session/client/SessionManager.ts Outdated
Comment thread src/tempo/session/client/SessionManager.ts Outdated
@parvahuja
parvahuja force-pushed the parv/fix-session-response-recovery branch from f7c5603 to 38e3bbd Compare August 26, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant