chore(deps-dev): bump @types/node to 24.13.6 - #638
Merged
Merged
Conversation
Lockfile-only patch bump within the existing "^24.13.2" range, so package.json is unchanged. Deliberately stays on the 24.x line. Dependabot proposed 26.0.1 in #595, but .nvmrc pins Node 24, so types for Node 26 would let TypeScript accept APIs that do not exist at runtime. Matching the types major to the runtime major matters more than being on the newest types. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Code Review by QodoNo Changes in PRQodo reviewed your PR and found no changes in the codeTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #595.
Lockfile-only bump of
@types/nodefrom 24.13.2 to 24.13.6, inside the existing"^24.13.2"range —package.jsonis unchanged.Why not 26, as #595 proposed
Dependabot wanted
@types/node26.0.1. That is a major bump out of the declared caret,and it would put the type definitions two majors ahead of the runtime:
.nvmrcpins Node 24 (fix: align Node version across workflows and loosen the .nvmrc pin #636).nvmrcpackage.jsondeclares"@types/node": "^24.13.2"Types for Node 26 on a Node 24 runtime means TypeScript accepts APIs that are not there
when the code runs — the compiler stops being able to tell you about a genuine mistake.
Keeping the types major aligned with the runtime major is worth more than being on the
newest types.
When the project moves to Node 26,
.nvmrcand@types/nodeshould move together.Verification
npm run build-ts— compiles successfully, no new type errorsnpx vitest run— 30 passed, 9 skippedpackage-lock.jsononly;dist/andtypes/are untouchedThe rest of the Dependabot queue
The other seven open Dependabot PRs are already satisfied on
devand need no action —they only appear open because they are based on
master, which is 20 commits behind:devhasnpm auditondevreports 0 vulnerabilities. Those seven should close themselves oncedevreachesmasterat the next release, rather than being closed by hand.🤖 Generated with Claude Code