Repository navigation
[BUGFIX] DPL-240: Remove .Build/vendor before composer update - #114
Merged
Merged
Conversation
composerUpdate removed "vendor", but the vendor directory of this
package is ".Build/vendor" ("config.vendor-dir"). A switch between
the core versions with "-t" therefore updated on top of the previous
installation, and a composer plugin changing its version in between
ran its old code against the new files, for example:
Class "TYPO3\ClassAliasLoader\IncludeFile\CaseSensitiveToken"
not found
The runner now removes ".Build/vendor", and ".Build/bin" with it,
whose proxies composer would otherwise skip as "name conflicts with
an existing file", as deepltranslate-core does.
Refs: DPL-240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composerUpdate removed "vendor", but the vendor directory of this
package is ".Build/vendor" ("config.vendor-dir"). A switch between
the core versions with "-t" therefore updated on top of the previous
installation, and a composer plugin changing its version in between
ran its old code against the new files, for example:
Class "TYPO3\ClassAliasLoader\IncludeFile\CaseSensitiveToken"
not found
The runner now removes ".Build/vendor", and ".Build/bin" with it,
whose proxies composer would otherwise skip as "name conflicts with
an existing file", as deepltranslate-core does.
YouTrack: https://youtrack.web-vision.de/issue/DPL-240