Repository navigation
[TASK] DPL-238: Pass CI_PARAMS to docker containers - #112
Merged
Merged
Conversation
The runner reads CI_PARAMS from the environment to pass additional options to "docker run", but only the podman branch used it. With docker the variable was silently ignored, so there was no way to hand e.g. COMPOSER_AUTH into the containers without editing the script. The docker branch now adds it at the same place as the podman branch. Without CI_PARAMS the generated commands are unchanged. Refs: DPL-238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runner reads CI_PARAMS from the environment to pass additional
options to "docker run", but only the podman branch used it. With
docker the variable was silently ignored, so there was no way to hand
e.g. COMPOSER_AUTH into the containers without editing the script.
The docker branch now adds it at the same place as the podman branch.
Without CI_PARAMS the generated commands are unchanged.
YouTrack: https://youtrack.web-vision.de/issue/DPL-238