[TASK] DPL-224: Drop the Composer patch plumbing - #100
Merged
Merged
Conversation
The package never declared a Composer patch of its own. It only carried the `vaimo/composer-patches` requirement, the matching `allow-plugins` entry, the `extra.patches-search` setting and an empty `patches/` directory so that a patch declared by a dependency would be applied in its own test installation. `web-vision/deepltranslate-core` is dropping that declaration, because the object form it uses is only understood by `vaimo/composer-patches` and lets `cweagans/composer-patches` abort the Composer run of a project. With nothing left to apply, the plumbing here is dead weight and is removed.
The DeepL packages stop shipping the Composer patch for the TYPO3 Core defect forge #110281 (translations with an empty `l10n_source` are invisible to `BackendUtility::getRecordLocalization()`). The fix is released upstream with TYPO3 v13.4.34 and v14.3.6, so the whole portfolio raises its lower bound to those versions instead of patching older ones. This package is not affected by the defect itself, but it is always installed together with the packages that are. Keeping one common lower bound avoids a resolution in which they disagree, and keeps the `ext_emconf.php` constraints in sync with `composer.json` for non Composer installations.
Documentation renderingYou can find files attached to the below linked Workflow Run URL (Logs). Please note that files only stay for around 5 days!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the portfolio wide cleanup for
web-vision/deepltranslate-core#646.
web-vision/deepltranslate-coredeclares the TYPO3 Core patch for forge#110281 in
extra.patches, using the object form(
{"source": …, "version": …}) that onlyvaimo/composer-patchesunderstands.
cweagans/composer-patchesexpects a plain URL string thereand aborts the Composer run of a project with "Array to string
conversion" (1.7.3) or a type error in
ResolverBase(2.0.0).The declaration is therefore dropped from the whole portfolio. This
package never declared a patch itself; it only carried the plumbing so a
declaration of a dependency would be applied in its own test install:
vaimo/composer-patchesinrequire-devand inconfig.allow-pluginsextra.patches-searchpatches/directoryAll of it is removed here.
The upstream fix is released with TYPO3 v13.4.34 and v14.3.6, so the
lower bound is raised to those versions instead of patching older ones —
in
composer.jsonand inext_emconf.php.Refs: DPL-224