[Server] Register skills from PHP code (dynamic content) - #2
Draft
wachterjohannes wants to merge 1 commit into
Draft
wachterjohannes wants to merge 1 commit into
wachterjohannes wants to merge 1 commit into
Conversation
Follow-up to modelcontextprotocol#372. Scope: a Builder/SkillProvider entry point for registering a skill's frontmatter and files from PHP-generated content (templates, computed text) rather than only from real files on disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to modelcontextprotocol#372: a way to register a skill's
SKILL.mdand supporting files from PHP-generated content (templates, computed text), not only from real files on a directoryaddSkillsFromDirectory()walks.SkillProvider::registerSkill()currently computes each resource's digest and size viahash_file()/filesize()and serves content vianew \SplFileInfo($absolute), so it assumes real files on disk. This PR needs a parallel path: content supplied as strings or closures per skill, with digest and size computed from the generated bytes, registered as a resource the same wayBuilder::addResource()already accepts a closure.Mcp\Server\Skill\SkillRegistry::add(Skill $skill)is already public, so a hand-built entry can be registered today without new API; the gap is a convenience layer with ergonomics similar toaddSkillsFromDirectory().No code yet — opened to track scope and target this against
feature/skills-extensionrather than wait for modelcontextprotocol#372 to merge upstream.