fix: preserve agent step limits - #78
Merged
Merged
Conversation
Object.fromEntries already yields Record<string, AgentConfig> for a typed entries array, so the assertion is dead weight under the stricter no-unnecessary-type-assertion in typescript-eslint 8.65.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
steps/maxStepswhen micode overlays plugin agentsstepsandmaxStepsthrough sanitizedmicode.jsonagent overridesRoot cause
micode built the plugin agent map and then spread those agents directly over
config.agent. That replaced the existing OpenCode agent object, so fields configured outside the plugin overlay, including iteration limits such assteps, were silently dropped.Validation
bun run checkbun run buildgit diff --checkCloses #53
Summary by cubic
Preserves user-configured agent iteration limits (
steps,maxSteps) when plugin agents overlay OpenCode defaults, and allows these fields in sanitizedmicode.jsonoverrides.Bug Fixes
config.agentviamergePluginAgentsto keep fields likesteps/maxSteps.stepsandmaxStepsinAgentOverrideschema and safe properties.Refactors
Object.fromEntriesto satisfytypescript-eslint8.65 rules.Written for commit 664e196. Summary will update on new commits.