Skip to content

For emphasis, using asterisks to bold and italicize the middle of a word doesn't work. #557

Description

@arjun2

For emphasis, using asterisks to bold and italicize the middle of a word doesn't work.

  • Parser
  • HtmlRenderer
  • Formatter
  • FlexmarkHtmlParser
  • DocxRenderer
  • PdfConverterExtension
  • extension(s)

Example:
Input: "This is really***very***important text."

Expected: <p>This is really<em><strong>very</strong></em>important text.</p>

Actual: <p>This is really***very***important text.</p>

Activity

  1. arjun2 commented on Feb 28, 2023

    @arjun2
    Author

    Can I please get some help on this ? I was looking at options on Parser but don't see any thing that can help.
    Note that it works with https://github.com/commonmark/commonmark-java

  2. david-waltermire commented on Jun 10, 2023

    @david-waltermire

    @arjun2 I am seeing the same. This is example 415 from the CommonMark specification.

    A parser creates the following AST:

    Document[0, 16]
      Paragraph[0, 16]
        Text[0, 15] chars:[0, 15, "foo** … **baz"]
    

    Notice the missing StrongEmphasis and Emphasis nodes.

    This seems like a bug in Flexmark.

  3. david-waltermire commented on Jun 10, 2023

    @david-waltermire

    Tracing this, I believe the problem relates to the code at:

    https://github.com/vsch/flexmark-java/blame/cc3a2f59ba6e532833f4805f8134b4dc966ff837/flexmark/src/main/java/com/vladsch/flexmark/parser/internal/InlineParserImpl.java#L1418

    It looks like the loop here is rewinding the stack to find the outer most opener and closer. Then processing the result.

    This code is a bit complex, so I am not fully sure what is happening, but this seems to result in the delimiters getting ignored.

  4. david-waltermire commented on Jun 10, 2023

    @david-waltermire

    @vsch Is there a possibility of prioritizing a fix? I am not sure I am able to fully debug this to create a PR or I would.

  5. added 3 commits that reference this issue on Jun 23, 2023
    d8ef7a9
    459ec25
    b22c465
  6. david-waltermire commented on Jun 24, 2023

    @david-waltermire

    @vsch Is there a possibility of prioritizing a fix? I am not sure I am able to fully debug this to create a PR or I would.

    I was able to create a PR after all. Let me know if this works or needs adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions