Honor sliceAllocLimit: compare the flag against zero - #402
Open
AshSgDe29071999 wants to merge 1 commit into
Open
AshSgDe29071999 wants to merge 1 commit into
AshSgDe29071999 wants to merge 1 commit into
Conversation
disableAllocLimitFlag is 8, so `flags&flag != 1` was always true and the 1,000,000-element cap never applied. DecodeSlice also preallocated capacity from the untrusted array length. See vmihailenco#401
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disableAllocLimitFlagis1<<3(8), soflags&flag != 1was always true and the 1,000,000-element cap never applied.DecodeSlicealso preallocated capacity from the untrusted array length.Compare the flag against zero, matching the rest of the decoder, and cap
[]interface{}capacity.Fixes #401
Test
go test . -run TestAllocLimitFlagIsHonored -count=1