fix: honor custom codecs for slices of named uint8 types - #399
Open
sonnemusk wants to merge 1 commit into
Open
Conversation
[]byte-kind shortcut no longer overrides CustomEncoder/CustomDecoder (or Marshaler/Unmarshaler) on named uint8 element types (vmihailenco#391). Plain []byte still uses binary encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
[]byte-kind shortcut no longer applies when the element type implements a custom codec (CustomEncoder/CustomDecoder,Marshaler/Unmarshaler, or binary/text marshaler interfaces).Why
Named
uint8types with custom encode/decode were packed as raw bin blobs in slices, while scalars used the custom codec. That is inconsistent and surprising.Plain
[]bytestill uses binary encoding.Fixes #391.
Test
TestNamedUint8SliceUsesCustomCodec