fix: honor element custom codecs for uint8 slices - #395
Closed
Solaris-star wants to merge 1 commit into
Closed
Conversation
Slices whose element kind is uint8 were always encoded/decoded as binary blobs, even when the element type implemented CustomEncoder/CustomDecoder (or Marshaler/Unmarshaler). Scalar values of the same type correctly used the custom codec. Skip the []byte shortcut when the element type provides a custom codec so []Role encodes as an array of custom values and can decode from such an array. Fixes #391
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Named
uint8element types that implementCustomEncoder/CustomDecoderwere still packed as msgpackbinwhen used in a slice:Fix
In encoder/decoder type dispatch, only take the
[]byteshortcut when the element type has no custom codec (value or pointer receiver).Test plan
go test .TestByteKindSliceHonorsElementCustomCodecFixes #391