Skip to content

fix(ui): replace [dev] debug label with skill icon in Automation Advisor (#5934) - #5993

Merged
vivekchand merged 3 commits into
mainfrom
bot-fix/issue-5934-remove-dev-debug-label-in-automation
Sep 15, 2026
Merged

vivekchand merged 3 commits into
mainfrom
bot-fix/issue-5934-remove-dev-debug-label-in-automation

Conversation

@vivekchand

@vivekchand vivekchand commented Sep 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

The Automation Advisor's suggestion renderer used the bare text [dev] as the icon for skill-type suggestions — a debug placeholder that slipped into the shipped bundle. This replaces it with 🧬, consistent with the existing node-skills icon in COMP_MAP. A companion static-analysis test prevents the same class of label from re-entering unnoticed.

No-PRD: cosmetic debug-label fix; already covered by REQ-OBS-CEA-023 acceptance criteria tracked in #5934

Changes

  • clawmetry/static/js/app.js:27082 — '[dev]' → '🧬' in loadAutomationAdvisorData's typeIcon expression
  • tests/test_cost_optimizer_demo_honesty.py — new test_no_debug_label_text_in_app_js that regex-scans all of app.js for bracket-style debug labels ([dev], [prod], [debug], [test]), so the guard covers every function, not just the rendered cost-optimizer body

Test plan

  • python3 -m pytest tests/test_cost_optimizer_demo_honesty.py -q — both the new test and test_modal_renders_basis_and_no_debug_label should pass
  • Open the Flow tab → click the Cost Optimizer or Brain node → confirm skill-type automation suggestions show 🧬 not [dev]

Bot meta

Draft PR opened autonomously based on the plan in #5934. Marked draft for human review — mark Ready for Review once happy.

The 33s cold-load spinner is tracked separately in #5935 (open PR). The provenance/figure labelling, 402 upgrade-prompt and time-travel message are already fixed in the current code; only this debug label remained.

Closes #5934


🤖 Generated with Claude Code

https://claude.ai/code/session_01NTMYY4MukDVJ4haD8Lo2SL

…sor (#5934)

`loadAutomationAdvisorData` used the bare text `[dev]` as the icon for
skill-type suggestions — a debug placeholder left from development.
Replace it with 🧬, consistent with the `node-skills` icon at line 25480.

Add `test_no_debug_label_text_in_app_js` to guard against this class of
regression across all functions in app.js, not just the rendered
cost-optimizer body.

Closes #5934

Co-Authored-By: ClawMetry Autofix Bot <bot-autofix@clawmetry.dev>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTMYY4MukDVJ4haD8Lo2SL
@github-actions

Copy link
Copy Markdown
Contributor

Visual diff

Comparing 09fcba3a2729 (head) against the PR base branch.

41 of 70 comparison(s) flagged (>1% pixel diff).

View Before After Diff
desktop overview before after diff · 0.01%
desktop flow before after diff · 0.02%
desktop brain before after diff · 0.00%
desktop usage ⚠️ before after diff · 100.00%
desktop crons before after diff · 0.00%
desktop memory ⚠️ before after diff · 100.00%
desktop security ⚠️ before after diff · 100.00%
desktop subagents ⚠️ before after diff · 100.00%
desktop transcripts before after diff · 0.00%
desktop logs ⚠️ before after diff · 100.00%
desktop skills before after diff · 0.01%
desktop models ⚠️ before after diff · 100.00%
desktop approvals before after diff · 0.00%
desktop alerts ⚠️ before after diff · 100.00%
desktop notifications before after diff · 0.02%
desktop limits ⚠️ before after diff · 100.00%
desktop history before after diff · 0.00%
desktop channels ⚠️ before after diff · 100.00%
desktop harness ⚠️ before after diff · 100.00%
desktop inventory before after diff · 0.20%
desktop nemoclaw ⚠️ before after diff · 3.13%
desktop guard ⚠️ before after diff · 100.00%
desktop signals before after diff · 0.01%
desktop policy before after diff · 0.44%
desktop selfevolve ⚠️ before after diff · 2.04%
desktop swimlane ⚠️ before after diff · 100.00%
desktop tool-catalog before after diff · 0.00%
desktop tracing before after diff · 0.02%
desktop turn-anatomy before after diff · 0.36%
desktop version-impact ⚠️ before after diff · 1.78%
desktop context-economics ⚠️ before after diff · 3.09%
desktop agents ⚠️ before after diff · 1.97%
desktop evals before after diff · 0.01%
desktop bench ⚠️ before after diff · 100.00%
desktop trail before after diff · 0.01%
mobile overview before after diff · 0.00%
mobile flow ⚠️ before after diff · 1.20%
mobile brain before after diff · 0.21%
mobile usage before after diff · 0.00%
mobile crons before after diff · 0.50%
mobile memory ⚠️ before after diff · 4.64%
mobile security before after diff · 0.03%
mobile subagents ⚠️ before after diff · 100.00%
mobile transcripts before after diff · 0.01%
mobile logs before after diff · 0.01%
mobile skills before after diff · 0.07%
mobile models before after diff · 0.00%
mobile approvals ⚠️ before after diff · 100.00%
mobile alerts before after diff · 0.00%
mobile notifications ⚠️ before after diff · 1.31%
mobile limits ⚠️ before after diff · 2.51%
mobile history before after diff · 0.04%
mobile channels ⚠️ before after diff · 2.52%
mobile harness ⚠️ before after diff · 100.00%
mobile inventory ⚠️ before after diff · 2.30%
mobile nemoclaw ⚠️ before after diff · 100.00%
mobile guard ⚠️ before after diff · 3.21%
mobile signals ⚠️ before after diff · 4.53%
mobile policy ⚠️ before after diff · 3.88%
mobile selfevolve before after diff · 0.01%
mobile swimlane ⚠️ before after diff · 3.71%
mobile tool-catalog ⚠️ before after diff · 1.69%
mobile tracing ⚠️ before after diff · 1.08%
mobile turn-anatomy ⚠️ before after diff · 1.01%
mobile version-impact ⚠️ before after diff · 3.37%
mobile context-economics ⚠️ before after diff · 1.18%
mobile agents ⚠️ before after diff · 1.69%
mobile evals ⚠️ before after diff · 8.16%
mobile bench ⚠️ before after diff · 4.53%
mobile trail ⚠️ before after diff · 3.26%

Folder: 09fcba3a2729. Full PNGs also attached as a workflow artefact.

Generated by visual-diff bot. Pixel diffs >1% flagged; eyeball the table before merging. This check is non-blocking — fail = bot bug, not a code problem.

Copy link
Copy Markdown
Owner Author

E2E Gate (required) — runner queue timeout, not a code regression

The E2E Gate failed after its 3600s (60-minute) timeout. The gate aggregates sub-checks and times out when any of them don't start. In this run, 7 sub-checks never received a GitHub Actions runner within that window:

  • MOAT Keystone (0/1 runners assigned)
  • E2E Browser Tests (0/1)
  • MOAT Verifier (0/1)
  • Entitlement API tests (0/1)
  • Store invariants (0/1)
  • API Tests (2/3 — one shard starved)
  • pip install matrix (2/4 — two shards starved)

All pending jobs were then cancelled at 22:18:59 UTC by the queue-priority.yml concurrency group when the main branch moved. Every check that did complete passed: CodeQL, security audit, vendored assets, action references, Python dependency audit, OSS golden path, Windows/macOS API tests, Windows/macOS pip install, cross-repo handoff, and others.

This is a GitHub Actions runner availability issue. The change in this PR — replacing '[dev]' with '🧬' at one line in app.js — cannot cause MOAT Keystone or E2E Browser Tests to fail to obtain runners. A new CI run is needed; either push a new commit or manually re-run the failed workflows from the Actions tab.


Generated by Claude Code

@vivekchand
vivekchand marked this pull request as ready for review September 15, 2026 12:37
@8090-software-factory

Copy link
Copy Markdown

✅ Drift Bot (ClawMetry): no drift detected

Drift Bot analyzed the changed files against this project's blueprints and requirements and found no drift.

@8090-software-factory

Copy link
Copy Markdown

✅ Drift Bot (ClawMetry): no drift detected

Drift Bot analyzed the changed files against this project's blueprints and requirements and found no drift.

docs/ATLAS_OPENCLAW_SCORECARD.md was stale after the main merge:
framework_map.py moved from mapping version 2026-09-14.1 to 2026-09-14.2
(landed in main via #5944/#5952). One line in the generated preamble
was out of date; re-running gen_atlas_openclaw_scorecard.py fixes it.

No-PRD: generated file sync; no product logic changed

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTMYY4MukDVJ4haD8Lo2SL
@8090-software-factory

Copy link
Copy Markdown

✅ Drift Bot (ClawMetry): no drift detected

Drift Bot analyzed the changed files against this project's blueprints and requirements and found no drift.

@vivekchand
vivekchand merged commit 24205bd into main Sep 15, 2026
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cost Optimizer: 33s spinner on cold load, debug label and unlabelled figures

1 participant