Replace custom Asserting function with built-in asserting keyword#421
Open
jcp19 wants to merge 1 commit into
Open
Replace custom Asserting function with built-in asserting keyword#421jcp19 wants to merge 1 commit into
jcp19 wants to merge 1 commit into
Conversation
Replace all usages of the Asserting helper function with Gobra's new native asserting expression (viperproject/gobra#1036) and remove the now-unused Asserting function definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the custom
Assertingghost function and replaces its usages with Gobra's built-inassertingkeyword, which provides the same functionality with better language integration.Key Changes
Assertingghost function definition fromverification/utils/definitions/definitions.gobralet _ := Asserting(...)with theasserting (...)keyword inpkg/slayers/scion_spec.gobra:EqAbsHeadermethod (lines 423-424)ValidPktMetaHdrfunction (line 465)Implementation Details
The
assertingkeyword is a built-in Gobra construct that serves the same purpose as the removedAssertingfunction - it allows assertion of properties within expressions. By using the native keyword instead of a custom wrapper function, the code becomes more idiomatic and reduces unnecessary indirection.https://claude.ai/code/session_01GeaBhWs7mdKisBuWBRXdt3