Repository navigation
test: await hydration before clicking counter (fix flaky tests) - #232
Merged
Merged
Conversation
Clicking repeatedly inside autoRetry() until the value changes is flaky: a click can land while the previous one is still being processed, overshooting the expected value. Port of vikejs/vike#3570. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EpJz8JiJnc1w9sPetPpxD6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of vikejs/vike#3570.
Clicking the counter repeatedly inside
autoRetry()until the value changes is flaky: a click can land while the previous one is still being processed, so the value can go past the expected number. Instead, the tests now wait for hydration (window._vike.fullyRenderedUrl), click once, and then useautoRetry()only for the assertion.Applied to the same pattern in:
examples/minimal/.testRun.tsexamples/redux/.testRun.tsexamples/zustand/.testRun.tsexamples/sentry/.testRun.tsVerified locally: all e2e test files for these four examples pass (dev + preview/prod).
馃 Generated with Claude Code
https://claude.ai/code/session_01EpJz8JiJnc1w9sPetPpxD6
Generated by Claude Code