Skip to content

fix: let the app's htmlAttributes/bodyAttributes take precedence over the ones set by Vike extensions #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brillout merged 1 commit into from
Sep 19, 2026
Merged

fix: let the app's htmlAttributes/bodyAttributes take precedence over the ones set by Vike extensions #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/vike-react/src/integration/getHeadSetting.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,13 @@ function getHeadSetting<T>(
if (valFromHook !== undefined) return valFromHook as any
return getCallable(valFromConfig) as any
} else {
// Sorted by increasing precedence: the values set by Vike extensions come first, then the app's values (the most
// specific one last), then the values set by useConfig(). Merging the list in order (e.g. with Object.assign())
// thus yields the value with the highest precedence.
return [
//
...((valFromConfig as any) ?? []).map(getCallable),
// pageContext.config[configName] is sorted by decreasing precedence (the most specific value first, the values set
// by Vike extensions last) => we reverse it. (We copy the list first: pageContext.config is shared.)
...[...((valFromConfig as any) ?? [])].reverse().map(getCallable),
...((valFromHook as any) ?? []),
] as any
}
Expand Down
Loading