fix: prevent Net::ReadTimeout on reused TCP connections#41
Merged
Kaevan89 merged 4 commits intoJul 3, 2026
Merged
Conversation
…y in Veryfi::Request. Update version to 4.0.1.
andresgarcia-verify
force-pushed
the
fix/stale-connection-read-timeout
branch
from
July 3, 2026 16:04
78c117c to
4d929f9
Compare
…tale connection recovery. Introduce attempt_request method to manage retries on Faraday::TimeoutError. Update tests to reflect new error handling behavior.
…net_http to 3.4.4, and json to 2.20.0 for improved compatibility and security.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memoising the Faraday connection with
@_conn ||=caused the adapter to reuse the same TCP socket across sequential requests. When the Veryfi API server closed a keep-alive connection after a heavy bank-statement upload, the next request attempted to write to an already-closed socket, raising:Net::ReadTimeout with #TCPSocket:(closed)
Fix: remove the memoisation so every request builds a fresh Faraday connection (and therefore a fresh TCP socket). The overhead of an extra TCP handshake (~50 ms) is negligible compared to the seconds each document-processing request takes.
Also aligns the default timeout with veryfi-python (30 s → was 20 s) and adds a regression spec asserting that
#connnever returns a cached object.Closes #