Repository navigation
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teams with npm credentials stored in Vercel need a CLI option to use them in a Sandbox. Add the bare
--npm-credentialsflag tosandbox create,sandbox run, andsandbox sh, backed by SDK support forcredentials: { npm: true }.npm-only requests require no Git repository or GitHub identity and keep the normal resource defaults. The review shows npm access before creation; scripts use
--yes. Saved configurations and retry commands preserve the npm setting. Missing credentials produce setup instructions forNPM_TOKENorNPM_RCinstead of a generic rejection. Includes CLI help, examples, the Sandbox skill, and package changesets.Dependencies: This PR is based on vercel/sandbox#435, the end of the existing managed-credentials CLI stack. Review against that base. Do not release until vercel/api#103708 has merged, Security has approved the backend, and the feature is enabled for the intended projects. The existing
--enable-managed-credentialsGitHub defaults are unchanged; combined access requires both flags.Validation: 727 CLI tests and 456 SDK tests passed (83 SDK tests skipped), SDK/CLI typechecks and builds passed. After tightening the SDK type to reject empty credential objects, 147 affected tests, six compile-time assertions, typechecks, and builds passed again. Executed the built CLI with a mocked API to verify the npm request body, no creation during dry-run, and actionable missing-credentials output. A live private-package install remains untested pending the backend rollout.