Skip to content

[managed credentials 01/17] SDK managed credential request and session contracts - #420

Closed
scubbo wants to merge 2 commits into
mainfrom
scubbo/managed-credentials-01-sdk
Closed

scubbo wants to merge 2 commits into
mainfrom
scubbo/managed-credentials-01-sdk

Conversation

@scubbo

@scubbo scubbo commented Oct 30, 2026 •

Copy link
Copy Markdown

Automated implementation split from #419 for focused human review.

Review scope

Add Git/API action types, explicit read-only source transport, optional nonsecret session metadata, and no automatic creation retries.

This is layer 1/17. Review the diff against the PR base, not against main. Each layer includes its owning tests and a changeset. Earlier layers do not enable the command surface. There are no dependency additions.

Stack

Base: main at f2ef3eb. The next layer targets this branch. Merge in sequence after review, not as one combined change.

Validation

Isolated clean-worktree validation at 51f90385de21e001b2668f6b517e24462789becc: CLI build, typecheck and full tests passed. Focus: SDK transport and response-validator tests.
Test summary: 452 passed | 83 skipped (535), 372 passed (372).
The first layer also passed SDK build, typecheck and the full SDK suite. Network/provider behavior is mocked. No production policy, Sandbox or flag was changed.

Deliberate limits

Legacy CLI credential flags and legacy configuration normalization are not carried forward. Deployed SDK/API compatibility is separate and retained.
Read-only source creation and reusable session metadata require backend support. The final stack reads project Bounds presence. It never provisions or changes project policy.
Backend handoff: https://github.com/vercel/api/blob/scubbo/managed-credentials-api-devbox-context/_doc/managed-credentials-devbox-context.md

Navigation: previous main; next #421. Full stack index.

Latest validation: c56fdf99aa00ceac849a0616c6b1b94de0bafe25 passed isolated CLI build, typecheck and all tests after the automated review/CI fixes. Ancestor fixes are propagated by merges, not force pushes. The SDK/mock export parity failure is fixed in layer 01; owning review findings are fixed in their own layers. See the current checks and full stack index for remote CI outcomes.

GitHub namespace, Bounds consent, and access presets

Automated implementation update (not from Jack).

No SDK code changes in this follow-up. The descriptions and navigation now identify the 17-layer stack.

The granular flags now use --credentials-github-*. The separate GitHub access preset PR is layer 17/17: read selects Git read plus four read-only API actions; write selects Git write plus all 11 supported GitHub API actions. Neither preset adds workflow-file write access.

The stack retains Melkey's suggested explicit-command recovery after rejection. Discussion. Existing attribution and review history above are retained.

Current head: c56fdf99aa00ceac849a0616c6b1b94de0bafe25. Local validation: No code changed in this follow-up.

Saved-login preview in the final layer

Automated implementation update (not from Jack).

PR #440 adds the follow-up for create --enable-github-credentials --dry-run. The final layer reuses saved Vercel login to discover an existing default team/project with read-only API calls. It does not refresh tokens or create a missing project. That follow-up also applies the final enable-flag name in help, examples, diagnostics, and rejected-command recovery. This note does not expand this layer's code scope. Existing Melkey attribution and review history are retained.

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sandbox Ready Ready Preview, v0 Oct 30, 2026 10:57pm UTC
sandbox-cli Ready Ready Preview, v0 Oct 30, 2026 10:57pm UTC
sandbox-sdk-ai-example Ready Ready Preview, v0 Oct 30, 2026 10:57pm UTC
workflow-code-runner Ready Ready Preview, v0 Oct 30, 2026 10:57pm UTC

@scubbo

scubbo commented Oct 30, 2026

Copy link
Copy Markdown
Author

Automated agent reply (not from Jack).
Automated agent fix (not from Jack): a bot automatically created commit c56fdf9, included in this branch.

The initial Publish run and its one retry failed because the mock package did not re-export the new SDK constants. This is introduced by the stack, not a known default-branch failure: the matching export test passes at main f2ef3eb and fails at the initial layer-01 revision. The mock now re-exports the constants and types.

Validation: a specific export regression failed before the fix and now passes. SDK: 452 passed, 83 skipped. Mock: 238 passed, 88 skipped. Final CLI: 639 passed. All layer heads passed isolated build/typecheck and full CLI tests. CI is pending or still being monitored for the new head c56fdf99aa00ceac849a0616c6b1b94de0bafe25. No force push was used.

@scubbo scubbo changed the title [managed credentials 01/16] SDK managed credential request and session contracts [managed credentials 01/17] SDK managed credential request and session contracts Nov 3, 2026
@LukeSheard
LukeSheard added this pull request to stack #443 November 4, 2026 13:49
@scubbo

scubbo commented Nov 5, 2026

Copy link
Copy Markdown
Author

Automated agent update (not from Jack).

Closing this PR so we can simplify and shorten the managed-credentials CLI implementation before requesting human review again. We will consolidate the current work into one draft PR and use it as the simplification workspace. The existing branch and review history are preserved. A follow-up comment will link the replacement draft.

@scubbo

scubbo commented Nov 5, 2026

Copy link
Copy Markdown
Author

Automated agent update (not from Jack).

Replacement draft: #449

That single draft contains the current managed-credentials CLI implementation and will be used to simplify and shorten the change before human review. This closed PR remains historical context. Its branch and review history are preserved. The replacement is a draft, not ready for approval or merge.

This branch was successfully deployed

4 active deployments
Preview – sandbox — c56fdf99 Deployed Oct 30, 2026 by vercel[bot]
Preview – sandbox-sdk-ai-example — c56fdf99 Deployed Oct 30, 2026 by vercel[bot]
Preview – workflow-code-runner — c56fdf99 Deployed Oct 30, 2026 by vercel[bot]
Preview – sandbox-cli — c56fdf99 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant