Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-npm-init.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eve": patch
---

Speed up fresh standalone npm scaffolds by skipping npm's resolution of unused optional peer dependencies. Existing projects and ancestor workspaces retain normal peer dependency resolution.
26 changes: 24 additions & 2 deletions packages/eve/src/cli/commands/init.integration.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,28 @@ describe("runInitCommand", () => {
},
);

it("keeps npm peer resolution for a fresh ancestor workspace member", async () => {
const workspaceRoot = await mkdtemp(join(tmpdir(), "eve-init-npm-workspace-member-"));
const appsDirectory = join(workspaceRoot, "apps");
await mkdir(appsDirectory, { recursive: true });
await writeFile(
join(workspaceRoot, "package.json"),
`${JSON.stringify({ private: true, workspaces: ["apps/*"] }, null, 2)}\n`,
"utf8",
);
await writeFile(join(workspaceRoot, "package-lock.json"), "", "utf8");
const output = logger();
const deps = dependencies();

await runInitCommand(output, appsDirectory, "my-agent", {}, deps);

expect(deps.runPackageManagerInstall).toHaveBeenCalledWith(
"npm",
join(appsDirectory, "my-agent"),
expect.objectContaining({ skipPeerDependencyResolution: false }),
);
});

it("adds Web Chat to an npm-owned fresh scaffold without pnpm configuration", async () => {
const parentDirectory = await mkdtemp(join(tmpdir(), "eve-init-agent-web-npm-"));
const output = logger();
Expand All @@ -720,7 +742,7 @@ describe("runInitCommand", () => {
expect(deps.runPackageManagerInstall).toHaveBeenCalledWith(
"npm",
projectPath,
expect.anything(),
expect.objectContaining({ skipPeerDependencyResolution: true }),
);
expect(deps.spawnPackageManager).toHaveBeenCalledWith("npm", projectPath, [
"exec",
Expand Down Expand Up @@ -1019,7 +1041,7 @@ describe("runInitCommand", () => {
expect(deps.runPackageManagerInstall).toHaveBeenCalledWith(
kind,
projectRoot,
expect.anything(),
expect.objectContaining({ skipPeerDependencyResolution: false }),
);
expect(deps.spawnPackageManager).toHaveBeenCalledWith(kind, projectRoot, [...devArguments]);
},
Expand Down
1 change: 1 addition & 0 deletions packages/eve/src/cli/commands/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,7 @@ async function runInitSteps(input: {
// The scaffold pins versions younger than typical release-age cooldown
// windows; gating them would fail every fresh bootstrap.
bypassMinimumReleaseAge: true,
skipPeerDependencyResolution: project.kind === "created" && !project.workspaceMember,
progressDetails: process.stdout.isTTY === true && !debug,
onOutput: (line) => {
if (line.text.trim() !== "") {
Expand Down
1 change: 1 addition & 0 deletions packages/eve/src/setup/primitives/pm/npm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export const npmPackageManager = {
installArguments: (options) => [
"install",
...(options.bypassMinimumReleaseAge === true ? ["--min-release-age=0"] : []),
...(options.skipPeerDependencyResolution === true ? ["--legacy-peer-deps"] : []),
...(options.progressDetails === true ? ["--loglevel=silly"] : []),
],
prepareArguments: (_projectRoot, args) => args,
Expand Down
2 changes: 2 additions & 0 deletions packages/eve/src/setup/primitives/pm/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ export interface PackageManagerInstallOptions {
readonly bypassMinimumReleaseAge?: boolean;
/** Resolves the project standalone even when an ancestor workspace exists. */
readonly ignoreWorkspace?: boolean;
/** Skips peer dependency resolution for an eve-owned standalone scaffold when supported. */
readonly skipPeerDependencyResolution?: boolean;
/** Requests verbose package-manager output for a live progress display. */
readonly progressDetails?: boolean;
}
Expand Down
16 changes: 16 additions & 0 deletions packages/eve/src/setup/primitives/run-pnpm.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,22 @@ describe("runPackageManagerInstall", () => {
);
});

test("skips npm peer dependency resolution when requested", async () => {
expect(
packageManagerInstallSucceeded(
await runPackageManagerInstall("npm", "/tmp/app", {
skipPeerDependencyResolution: true,
}),
),
).toBe(true);

expect(mockedSpawn).toHaveBeenCalledWith(
"npm",
["install", "--legacy-peer-deps"],
expect.objectContaining({ cwd: "/tmp/app" }),
);
});

test("requests npm output before registry operations complete", async () => {
expect(
packageManagerInstallSucceeded(
Expand Down
2 changes: 1 addition & 1 deletion packages/eve/test/scenarios/eve-init.scenario.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ describe("eve init smoke", () => {
await expect(pathExists(join(projectDir, "package-lock.json"))).resolves.toBe(true);
expect(await fakeNpm.readCalls()).toEqual([
{
args: ["install", "--min-release-age=0"],
args: ["install", "--min-release-age=0", "--legacy-peer-deps"],
cwd: canonicalProjectDir,
},
{
Expand Down
Loading